Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new method to fetch the config as json #137

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

prateek3255
Copy link
Contributor

Summary of change

Adds a new method to the interface to fetch the config of the plugin as json

Related issues

N/A

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

N/A

build.gradle Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@prateek3255 prateek3255 changed the base branch from 4.0 to feat/multitenancy-dashboard February 21, 2024 12:14
@sattvikc sattvikc merged commit 8d0605c into feat/multitenancy-dashboard Feb 28, 2024
2 checks passed
@sattvikc sattvikc deleted the add-config-method branch February 28, 2024 08:19
sattvikc added a commit that referenced this pull request May 24, 2024
* feat: Add a new method to fetch the config as json (#137)

* Add a new method to fetch the config as json

* Update changelog

* Revert version changes

* Update getConfigFieldInfo method implementation

* Add non null to not null fields

* Update getConfigFieldsInfo method signature in Storage interface

* Add @nullable annotation to ConfigFieldInfo class

* fix: core config list

* fix: core config

* fix: updated types

* fix: refactor config description

* fix: type fix

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: to json 5.0

* fix: version and changelog

* fix: rename

* fix: nullable

* fix: condition

* fix: changelog

* fix: refactor

---------

Co-authored-by: Sattvik Chakravarthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants