-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor custom framework utils to reuse them #933
Merged
rishabhpoddar
merged 30 commits into
21.0
from
feat/refactor-custom-framework-utils-to-reuse-them
Oct 7, 2024
Merged
feat: refactor custom framework utils to reuse them #933
rishabhpoddar
merged 30 commits into
21.0
from
feat/refactor-custom-framework-utils-to-reuse-them
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying supertokens-node-pr-check-for-edge-function-compat with Cloudflare Pages
|
rishabhpoddar
suggested changes
Oct 3, 2024
rishabhpoddar
suggested changes
Oct 3, 2024
rishabhpoddar
suggested changes
Oct 3, 2024
rishabhpoddar
suggested changes
Oct 4, 2024
deepjyoti30-st
force-pushed
the
feat/refactor-custom-framework-utils-to-reuse-them
branch
from
October 4, 2024 07:36
abea857
to
2d18d33
Compare
rishabhpoddar
suggested changes
Oct 4, 2024
Manual testing of the above points with the newer branch (besides the automated ones that I have already added): |
deepjyoti30-st
force-pushed
the
feat/refactor-custom-framework-utils-to-reuse-them
branch
from
October 7, 2024 08:06
c4868b8
to
75c4e28
Compare
rishabhpoddar
suggested changes
Oct 7, 2024
rishabhpoddar
deleted the
feat/refactor-custom-framework-utils-to-reuse-them
branch
October 7, 2024 11:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds support for exposing re-usable util functions that can be used for custom frameworks to minimize the code required to set them up.
Related issues
Test Plan
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
recipe/thirdparty/providers/configUtils.ts
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.add-ts-no-check.js
file to include thatsomeFunc: function () {..}
).exports
inpackage.json
Remaining TODOs for this PR