fix: Fix jwks body containing additional properties (#696)

* FIx GwtJWKS response to not contain additional properties * Bump package version and update CHANGELOG
supertokens · Sep 22, 2023 · 8af7acb · 8af7acb
1 parent d3229cb
commit 8af7acb
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+## [15.2.1] - 2023-09-22
+
+### Fixes
+
+-   Fixes an issue where the response for the JWKs API would contain additional properties
+
 ## [15.2.0] - 2023-09-11
 
 ### Added

diff --git a/lib/build/recipe/jwt/api/implementation.js b/lib/build/recipe/jwt/api/implementation.js
@@ -53,7 +53,9 @@ function getAPIImplementation() {
                 if (resp.validityInSeconds !== undefined) {
                     options.res.setHeader("Cache-Control", `max-age=${resp.validityInSeconds}, must-revalidate`, false);
                 }
-                return resp;
+                return {
+                    keys: resp.keys,
+                };
             });
         },
     };

diff --git a/lib/build/version.d.ts b/lib/build/version.d.ts
diff --git a/lib/build/version.js b/lib/build/version.js
diff --git a/lib/ts/recipe/jwt/api/implementation.ts b/lib/ts/recipe/jwt/api/implementation.ts
@@ -31,7 +31,9 @@ export default function getAPIImplementation(): APIInterface {
                 options.res.setHeader("Cache-Control", `max-age=${resp.validityInSeconds}, must-revalidate`, false);
             }
 
-            return resp;
+            return {
+                keys: resp.keys,
+            };
         },
     };
 }
diff --git a/lib/ts/recipe/jwt/recipeImplementation.ts b/lib/ts/recipe/jwt/recipeImplementation.ts
@@ -68,7 +68,7 @@ export default function getRecipeInterface(
             }
         },
 
-        getJWKS: async function (): Promise<{ keys: JsonWebKey[]; validityInSeconds: number }> {
+        getJWKS: async function (): Promise<{ keys: JsonWebKey[]; validityInSeconds?: number }> {
             const { body, headers } = await querier.sendGetRequestWithResponseHeaders(
                 new NormalisedURLPath("/.well-known/jwks.json"),
                 {}

diff --git a/lib/ts/version.ts b/lib/ts/version.ts
@@ -12,7 +12,7 @@
  * License for the specific language governing permissions and limitations
  * under the License.
  */
-export const version = "15.2.0";
+export const version = "15.2.1";
 
 export const cdiSupported = ["3.0"];
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "supertokens-node",
-    "version": "15.2.0",
+    "version": "15.2.1",
     "description": "NodeJS driver for SuperTokens core",
     "main": "index.js",
     "scripts": {

diff --git a/test/jwt/getJWKS.test.js b/test/jwt/getJWKS.test.js
@@ -115,6 +115,7 @@ describe(`getJWKS: ${printPath("[test/jwt/getJWKS.test.js]")}`, function () {
         });
 
         assert(response !== undefined);
+        assert(Object.keys(response).length === 1);
         assert(response.keys !== undefined);
         assert(response.keys.length > 0);
         assert.strictEqual(headers["cache-control"], "max-age=60, must-revalidate");