Skip to content

Commit

Permalink
feat: multithreaded bulk import (#136)
Browse files Browse the repository at this point in the history
* feat: multithreaded bulk import (#128)

* feat: Add bulk import queries

* fix: PR changes

* fix: PR changes

* fix: removing restriction of connection pool size for bulk import

* feat: enable test run trigger from ci by hand

* fix: enable test run trigger from ci by hand

* Updated config.yml

* fix: reverting CI changes

* "fix: reverting CI config changes"

This reverts commit 4586b90.

* fix: fixing transaction rolled back issues with multithreaded bulk import

* fix: changelog

* fix: put back accidentally deleted comment

* feat: mysql implementation for bulk import

* fix: using right transaction isolation level for mysql in bulkimport

* fix: review fix, onemillion user test move

* fix: fixing imports

---------

Co-authored-by: Ankit Tiwari <[email protected]>

* Update build.gradle

* Update pluginInterfaceSupported.json

---------

Co-authored-by: Tamas Soltesz <[email protected]>
Co-authored-by: Ankit Tiwari <[email protected]>
  • Loading branch information
3 people authored Dec 19, 2024
1 parent f2482ea commit 9fa239d
Show file tree
Hide file tree
Showing 22 changed files with 2,443 additions and 24 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

- Adds queries for Bulk Import
- Adds support for multithreaded bulk import

## [7.2.0] - 2024-10-03

- Compatible with plugin interface version 6.3
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ plugins {
id 'java-library'
}

version = "7.2.0"
version = "7.3.0"

repositories {
mavenCentral()
Expand Down Expand Up @@ -129,4 +129,4 @@ tasks.withType(Test) {
}
}
}
}
}
4 changes: 2 additions & 2 deletions pluginInterfaceSupported.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"_comment": "contains a list of plugin interfaces branch names that this core supports",
"versions": [
"6.3"
"6.4"
]
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,328 @@
/*
* Copyright (c) 2024, VRAI Labs and/or its affiliates. All rights reserved.
*
* This software is licensed under the Apache License, Version 2.0 (the
* "License") as published by the Apache Software Foundation.
*
* You may not use this file except in compliance with the License. You may
* obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/


package io.supertokens.storage.mysql;

import java.sql.*;
import java.util.Map;
import java.util.Properties;
import java.util.concurrent.Executor;

/**
* BulkImportProxyConnection is a class implementing the Connection interface, serving as a Connection instance in the bulk import user cronjob.
* This cron extensively utilizes existing queries to import users, all of which internally operate within transactions and those query sometimes
* call the commit/rollback method on the connection.
*
* For the purpose of bulkimport cronjob, we aim to employ a single connection for all queries and rollback any operations in case of query failures.
* To achieve this, we use our own proxy Connection instance and override the commit/rollback/close methods to do nothing.
*/

public class BulkImportProxyConnection implements Connection {
private Connection con = null;

public BulkImportProxyConnection(Connection con) {
this.con = con;
}

@Override
public void close() throws SQLException {
// We simply ignore when close is called BulkImportProxyConnection
}

@Override
public void commit() throws SQLException {
// We simply ignore when commit is called BulkImportProxyConnection
}

@Override
public void rollback() throws SQLException {
// We simply ignore when rollback is called BulkImportProxyConnection
}

public void closeForBulkImportProxyStorage() throws SQLException {
this.con.close();
}

public void commitForBulkImportProxyStorage() throws SQLException {
this.con.commit();
}

public void rollbackForBulkImportProxyStorage() throws SQLException {
this.con.rollback();
}

/* Following methods are unchaged */

@Override
public Statement createStatement() throws SQLException {
return this.con.createStatement();
}

@Override
public PreparedStatement prepareStatement(String sql) throws SQLException {
return this.con.prepareStatement(sql);
}

@Override
public CallableStatement prepareCall(String sql) throws SQLException {
return this.con.prepareCall(sql);
}

@Override
public String nativeSQL(String sql) throws SQLException {
return this.con.nativeSQL(sql);
}

@Override
public void setAutoCommit(boolean autoCommit) throws SQLException {
this.con.setAutoCommit(autoCommit);
}

@Override
public boolean getAutoCommit() throws SQLException {
return this.con.getAutoCommit();
}

@Override
public boolean isClosed() throws SQLException {
return this.con.isClosed();
}

@Override
public DatabaseMetaData getMetaData() throws SQLException {
return this.con.getMetaData();
}

@Override
public void setReadOnly(boolean readOnly) throws SQLException {
this.con.setReadOnly(readOnly);
}

@Override
public boolean isReadOnly() throws SQLException {
return this.con.isReadOnly();
}

@Override
public void setCatalog(String catalog) throws SQLException {
this.con.setCatalog(catalog);
}

@Override
public String getCatalog() throws SQLException {
return this.con.getCatalog();
}

@Override
public void setTransactionIsolation(int level) throws SQLException {
this.con.setTransactionIsolation(level);
}

@Override
public int getTransactionIsolation() throws SQLException {
return this.con.getTransactionIsolation();
}

@Override
public SQLWarning getWarnings() throws SQLException {
return this.con.getWarnings();
}

@Override
public void clearWarnings() throws SQLException {
this.con.clearWarnings();
}

@Override
public Statement createStatement(int resultSetType, int resultSetConcurrency) throws SQLException {
return this.con.createStatement(resultSetType, resultSetConcurrency);
}

@Override
public PreparedStatement prepareStatement(String sql, int resultSetType, int resultSetConcurrency)
throws SQLException {
return this.con.prepareStatement(sql, resultSetType, resultSetConcurrency);
}

@Override
public CallableStatement prepareCall(String sql, int resultSetType, int resultSetConcurrency) throws SQLException {
return this.con.prepareCall(sql, resultSetType, resultSetConcurrency);
}

@Override
public Map<String, Class<?>> getTypeMap() throws SQLException {
return this.con.getTypeMap();
}

@Override
public void setTypeMap(Map<String, Class<?>> map) throws SQLException {
this.con.setTypeMap(map);
}

@Override
public void setHoldability(int holdability) throws SQLException {
this.con.setHoldability(holdability);
}

@Override
public int getHoldability() throws SQLException {
return this.con.getHoldability();
}

@Override
public Savepoint setSavepoint() throws SQLException {
return this.con.setSavepoint();
}

@Override
public Savepoint setSavepoint(String name) throws SQLException {
return this.con.setSavepoint(name);
}

@Override
public void rollback(Savepoint savepoint) throws SQLException {
this.con.rollback(savepoint);
}

@Override
public void releaseSavepoint(Savepoint savepoint) throws SQLException {
this.con.releaseSavepoint(savepoint);
}

@Override
public Statement createStatement(int resultSetType, int resultSetConcurrency, int resultSetHoldability)
throws SQLException {
return this.con.createStatement(resultSetType, resultSetConcurrency, resultSetHoldability);
}

@Override
public PreparedStatement prepareStatement(String sql, int resultSetType, int resultSetConcurrency,
int resultSetHoldability) throws SQLException {
return this.con.prepareStatement(sql, resultSetType, resultSetConcurrency, resultSetHoldability);
}

@Override
public CallableStatement prepareCall(String sql, int resultSetType, int resultSetConcurrency,
int resultSetHoldability) throws SQLException {
return this.con.prepareCall(sql, resultSetType, resultSetConcurrency, resultSetHoldability);
}

@Override
public PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) throws SQLException {
return this.con.prepareStatement(sql, autoGeneratedKeys);
}

@Override
public PreparedStatement prepareStatement(String sql, int[] columnIndexes) throws SQLException {
return this.con.prepareStatement(sql, columnIndexes);
}

@Override
public PreparedStatement prepareStatement(String sql, String[] columnNames) throws SQLException {
return this.con.prepareStatement(sql, columnNames);
}

@Override
public Clob createClob() throws SQLException {
return this.con.createClob();
}

@Override
public Blob createBlob() throws SQLException {
return this.con.createBlob();
}

@Override
public NClob createNClob() throws SQLException {
return this.con.createNClob();
}

@Override
public SQLXML createSQLXML() throws SQLException {
return this.con.createSQLXML();
}

@Override
public boolean isValid(int timeout) throws SQLException {
return this.con.isValid(timeout);
}

@Override
public void setClientInfo(String name, String value) throws SQLClientInfoException {
this.con.setClientInfo(name, value);
}

@Override
public void setClientInfo(Properties properties) throws SQLClientInfoException {
this.con.setClientInfo(properties);
}

@Override
public String getClientInfo(String name) throws SQLException {
return this.con.getClientInfo(name);
}

@Override
public Properties getClientInfo() throws SQLException {
return this.con.getClientInfo();
}

@Override
public Array createArrayOf(String typeName, Object[] elements) throws SQLException {
return this.con.createArrayOf(typeName, elements);
}

@Override
public Struct createStruct(String typeName, Object[] attributes) throws SQLException {
return this.con.createStruct(typeName, attributes);
}

@Override
public void setSchema(String schema) throws SQLException {
this.con.setSchema(schema);
}

@Override
public String getSchema() throws SQLException {
return this.con.getSchema();
}

@Override
public void abort(Executor executor) throws SQLException {
this.con.abort(executor);
}

@Override
public void setNetworkTimeout(Executor executor, int milliseconds) throws SQLException {
this.con.setNetworkTimeout(executor, milliseconds);
}

@Override
public int getNetworkTimeout() throws SQLException {
return this.con.getNetworkTimeout();
}

@Override
public <T> T unwrap(Class<T> iface) throws SQLException {
return this.con.unwrap(iface);
}

@Override
public boolean isWrapperFor(Class<?> iface) throws SQLException {
return this.con.isWrapperFor(iface);
}
}
Loading

0 comments on commit 9fa239d

Please sign in to comment.