feat: Add an API to fetch the list of core config properties #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sattvikc
requested changes
Feb 7, 2024
src/main/java/io/supertokens/webserver/api/core/CoreConfigListAPI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/supertokens/config/annotations/DifferentAcrossTenants.java
Outdated
Show resolved
Hide resolved
sattvikc
requested changes
Feb 19, 2024
prateek3255
force-pushed
the
add-core-config-api
branch
from
f7d968e to
13f97ca
Compare
sattvikc
requested changes
Feb 22, 2024
sattvikc
requested changes
Feb 23, 2024
src/main/java/io/supertokens/webserver/api/core/CoreConfigListAPI.java
Outdated
Show resolved
Hide resolved
sattvikc
requested changes
Feb 23, 2024
sattvikc
approved these changes
Feb 28, 2024
sattvikc
added a commit
that referenced
this pull request
May 24, 2024
* feat: Add an API to fetch the list of core config properties (#922) * Add an API to fetch the coreConfig properties * Update changelog * Include plugin configs as well * Remove core_config_result from the final output * Hide protected config * Fix formatting changes * Add tests to ensure that the properties are same in the config and core config file * Match descriptions from devConfig.yaml as well * Refactor CoreConfig to return ConfigFieldInfo objects * Refactor enum property validation * Refactor move storage fields to API * Refactor getConfigFieldsInfo method and update CoreConfigListAPI * Add test to check protected properties are not present when saas secret is set * Add comments wherever necessary * fix: core config list * fix: serialize nulls * fix: is nullable * fix: plugin configs * fix: add new booleans for core config * fix: cleanup * fix: list apis * fix: refactor config description * fix: refactor cud tests * fix: refactor tests * fix: tests * fix: type fix * fix: flag setting for thirdparty providers * fix: pr comments * fix: pr comments * fix: pr comments * fix: pr comments * fix: revert * fix: tenant tests * fix: app tests * fix: cud tests * fix: other tests * fix: version and changelog * fix: inmemory * fix: skip deprecated * fix: dashboard updates * fix: minor fixes * fix: tests * fix: refactor * fix: refactor * fix: changelog * fix: refactor --------- Co-authored-by: Sattvik Chakravarthy <[email protected]> Co-authored-by: Sattvik Chakravarthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Related issues
N/A
Test Plan
N/A
Documentation changes
N/A
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any core config (similar to theaccess_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deleting the user as well ifdeleteUserIdMappingToois false.Remaining TODOs for this PR
N/A