Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user disassociation from all tenant #799

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

sattvikc
Copy link
Collaborator

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • If added a new paid feature, edit the getPaidFeatureStats function in FeatureFlag.java file
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Update function getValidFields in io/supertokens/config/CoreConfig.java if new aliases were added for any core config (similar to the access_token_signing_key_update_interval config alias).
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Sep 12, 2023
@@ -21,6 +21,7 @@
import io.supertokens.ProcessState;
import io.supertokens.authRecipe.AuthRecipe;
import io.supertokens.authRecipe.exception.AccountInfoAlreadyAssociatedWithAnotherPrimaryUserIdException;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change changelog as well

@sattvikc sattvikc merged commit 1971c2c into feat/account-linking Sep 13, 2023
2 of 3 checks passed
@sattvikc sattvikc deleted the al-delete-tenant branch September 13, 2023 04:48
rishabhpoddar added a commit that referenced this pull request Sep 20, 2023
* table schema changes

* changes to user count API

* small change

* implements changes to auth queries to fetch tenant ids and verified status

* fixes a few bugs

* more changes

* fixes query

* fixes tests

* all test fixes

* removes a few unnecessary functions

* uses new interface to fetch user based on id

* adds stub for new function

* removes use of unnecessary function

* changes based on interface

* adds function for list user by phone number

* optimises a query

* more intefrace function

* removes unused interface func

* adds migration script to changelog

* small changes

* refactor

* removes unneeded functions

* adds user get API

* get users by account info API

* adds new func signature

* creates new indices

* adds impl for creating a primary user

* implements one of the functions

* adds more query impls

* fixes small issue

* starts working on account linking tests

* adds a few tests

* adds more tests

* more tests

* adds link account function

* removes unneeded index

* adds test only func and also adds feature flag check

* more changes

* adds one account linking test

* adds more tests

* more tests

* more tests

* more tests

* more tests

* mods delete function

* small file change

* delete function change

* fixes a bug

* adds more tests

* adds unliking accounts function

* refactors for link accounts function

* more refactor

* adds API for can create primary user

* adds create primary user API, except for converting tuser obj to json

* fixes older APIs

* fixes tests

* removes unneeded file

* starts working on can link accounts api

* adds more tests

* more tests

* new tests

* adds tests for linking accounts API

* adds unlink accounts API

* adds more tests

* more changes

* changes for password reset flow

* more tests

* more tests

* implements consumeCode function

* adds API to consume reset password code

* adds more tests

* adds more tests

* removes unnecessary comment

* adds more tests

* updates to updatemeailorpassword function

* adds more tests

* updates tp sign in to check for email update allowance

* more tests

* adds more tests

* fixes a bug

* adds recipe user id in session

* adds session changes to changelog

* changes claim ro rsub

* changes API spec

* changes API spec

* changes to passwordless recipe update user

* renames variable

* fix: account linking tests (#764)

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: pr comments

* fix: pr comments

* fix: user pagination changes (#766)

* fix: user pagination changes

* fix: user pagination changes

* fix: remove extra wrapper around user objects in users list

* feat: update latest access token version

* fix: user pagination tests (#768)

* fix: user pagination tests

* fix: user pagination tests

* fix: recipeUserId in sign in/up related APIs (#769)

* fix: recipeUserId in sign in/up related APIs

* fix: phone and email case

* fix: pr comments

* fix: test with external user id

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: External userid (#770)

* fix: recipeUserId in sign in/up related APIs

* fix: phone and email case

* fix: pr comments

* fix: test with external user id

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: external userid

* fix: tests

* fix: user object in link accounts api (#771)

* fix: link accounts api

* fix: minor fix

* fix: tests

* fix: remove UserInfo class (#772)

* fix: remove UserInfo class

* fix: remove getRecipeId

* fix: uncomment test

* fix: emailverified in tp & pless (#774)

* fix: email verification in thirdparty and pless

* fix: email verification

* fix: more test for passwordless

* fix: thirdparty and tests

* fix: remove active user of recipe user when linked (#773)

* fix: remove active user of recipe user when linked

* fix: query

* fix: multitenant user association with account linking (#777)

* fix: test user association

* fix: multitenancy related changes

* fix: pr comments

* fix: pr comments

* fix: merge latest (#782)

* fix: add exp and iat to JWT payloads without scientific notation (#765)

* adding dev-v6.0.9 tag to this commit to ensure building

* fix: fix handling of b64 and b64url encoded access tokens (#767)

* adding dev-v6.0.10 tag to this commit to ensure building

* Update release.md

* Update release.md

* fix: ee featureflag cron job (#778)

* fix: ee featureflag cron job

* fix: test

* fix: tests

* fix: tests

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#779)

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#780)

* fix: test

* fix: test

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#781)

* adding dev-v6.0.11 tag to this commit to ensure building

---------

Co-authored-by: Mihály Lengyel <[email protected]>
Co-authored-by: rishabhpoddar <[email protected]>

* fix: tests (#776)

* fix: tests

* fix: removed removal of active user

* fix: user id mapping deletion

* fix: more fixes

* fix: user delete

* fix: test

* fix: test

* fix: session fix and thirdparty ev test

* fix: pr comments

* fix: pr comments

* fix: tests

* fix: phone number change related

* fix: get user by id as per recipe (#788)

* fix: updated migration (#790)

* fix: updated migration script

* fix: fkey constraint on primary_or_recipe_user_id (#791)

* fix: account linking stats (#792)

* fix: account linking stats

* fix: test

* fix: pr comments

* fix: updated test

* Merge latest 6.0.12 (#795)

* fix: add exp and iat to JWT payloads without scientific notation (#765)

* adding dev-v6.0.9 tag to this commit to ensure building

* fix: fix handling of b64 and b64url encoded access tokens (#767)

* adding dev-v6.0.10 tag to this commit to ensure building

* Update release.md

* Update release.md

* fix: ee featureflag cron job (#778)

* fix: ee featureflag cron job

* fix: test

* fix: tests

* fix: tests

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#779)

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#780)

* fix: test

* fix: test

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#781)

* adding dev-v6.0.11 tag to this commit to ensure building

* Update README.md (#783)

Corrected all the grammatical errors in the README file.

* fix: session concurrency issue (#785)

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: fixing ee folder issue when empty database at startup (#786)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: test (#787)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* fix: test

* adding dev-v6.0.12 tag to this commit to ensure building

* bug fixes

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: remove print

---------

Co-authored-by: Mihály Lengyel <[email protected]>
Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Abhisar Yadav <[email protected]>

* fix: tests for tenant association with unlinked account

* fix: email password update email

* fix: shared user in pless

* fix: recipe user association

* fix: ep login issues

* fix: allow user disassociation from all tenant (#799)

* fix: allow user disassociation from all tenants

* fix: multitenancy

* fix: updated changelog

* fix: rename userId to recipeUserId

* fix: function changes (#802)

* fix: account function changes

* fix: function updates

* fix: link and unlink accounts (#803)

* fix: password reset changes (#804)

* fix: adds recipe user id in session (#805)

* fix: fixes query (#806)

* fix: user pagination (#807)

* fix: multitenant user association (#808)

* fix: remove con reuse (#810)

* fix: index updates (#811)

* fix: fkey constraint (#812)

* fix: account linking stats (#813)

* fix: allow tenant disassociation (#814)

* fix: tests (#815)

* fix: tests

* fix: tests

* fix: license stats fix (#818)

* fix: add exp and iat to JWT payloads without scientific notation (#765)

* adding dev-v6.0.9 tag to this commit to ensure building

* fix: fix handling of b64 and b64url encoded access tokens (#767)

* adding dev-v6.0.10 tag to this commit to ensure building

* Update release.md

* Update release.md

* fix: ee featureflag cron job (#778)

* fix: ee featureflag cron job

* fix: test

* fix: tests

* fix: tests

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#779)

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#780)

* fix: test

* fix: test

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#781)

* adding dev-v6.0.11 tag to this commit to ensure building

* Update README.md (#783)

Corrected all the grammatical errors in the README file.

* fix: session concurrency issue (#785)

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: fixing ee folder issue when empty database at startup (#786)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: test (#787)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* fix: test

* adding dev-v6.0.12 tag to this commit to ensure building

* bug fixes

* adding dev-v6.0.12 tag to this commit to ensure building

* Update README.md

* Update README.md

* fix: stats fix (#816)

* fix: stats fix

* fix: pr comments

* fix: disable for in mem

* fix: pr comments

* adding dev-v6.0.13 tag to this commit to ensure building

---------

Co-authored-by: Mihály Lengyel <[email protected]>
Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Abhisar Yadav <[email protected]>

* fix: fixes for mongo plugin (#817)

* fix: version and changelog

* fix: schema updates

---------

Co-authored-by: Sattvik Chakravarthy <[email protected]>
Co-authored-by: Mihaly Lengyel <[email protected]>
Co-authored-by: Sattvik Chakravarthy <[email protected]>
Co-authored-by: Abhisar Yadav <[email protected]>
rishabhpoddar added a commit that referenced this pull request Sep 20, 2023
* table schema changes

* changes to user count API

* small change

* implements changes to auth queries to fetch tenant ids and verified status

* fixes a few bugs

* more changes

* fixes query

* fixes tests

* all test fixes

* removes a few unnecessary functions

* uses new interface to fetch user based on id

* adds stub for new function

* removes use of unnecessary function

* changes based on interface

* adds function for list user by phone number

* optimises a query

* more intefrace function

* removes unused interface func

* adds migration script to changelog

* small changes

* refactor

* removes unneeded functions

* adds user get API

* get users by account info API

* adds new func signature

* creates new indices

* adds impl for creating a primary user

* implements one of the functions

* adds more query impls

* fixes small issue

* starts working on account linking tests

* adds a few tests

* adds more tests

* more tests

* adds link account function

* removes unneeded index

* adds test only func and also adds feature flag check

* more changes

* adds one account linking test

* adds more tests

* more tests

* more tests

* more tests

* more tests

* mods delete function

* small file change

* delete function change

* fixes a bug

* adds more tests

* adds unliking accounts function

* refactors for link accounts function

* more refactor

* adds API for can create primary user

* adds create primary user API, except for converting tuser obj to json

* fixes older APIs

* fixes tests

* removes unneeded file

* starts working on can link accounts api

* adds more tests

* more tests

* new tests

* adds tests for linking accounts API

* adds unlink accounts API

* adds more tests

* more changes

* changes for password reset flow

* more tests

* more tests

* implements consumeCode function

* adds API to consume reset password code

* adds more tests

* adds more tests

* removes unnecessary comment

* adds more tests

* updates to updatemeailorpassword function

* adds more tests

* updates tp sign in to check for email update allowance

* more tests

* adds more tests

* fixes a bug

* adds recipe user id in session

* adds session changes to changelog

* changes claim ro rsub

* changes API spec

* changes API spec

* changes to passwordless recipe update user

* renames variable

* fix: account linking tests (#764)

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: pr comments

* fix: pr comments

* fix: user pagination changes (#766)

* fix: user pagination changes

* fix: user pagination changes

* fix: remove extra wrapper around user objects in users list

* feat: update latest access token version

* fix: user pagination tests (#768)

* fix: user pagination tests

* fix: user pagination tests

* fix: recipeUserId in sign in/up related APIs (#769)

* fix: recipeUserId in sign in/up related APIs

* fix: phone and email case

* fix: pr comments

* fix: test with external user id

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: External userid (#770)

* fix: recipeUserId in sign in/up related APIs

* fix: phone and email case

* fix: pr comments

* fix: test with external user id

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: external userid

* fix: tests

* fix: user object in link accounts api (#771)

* fix: link accounts api

* fix: minor fix

* fix: tests

* fix: remove UserInfo class (#772)

* fix: remove UserInfo class

* fix: remove getRecipeId

* fix: uncomment test

* fix: emailverified in tp & pless (#774)

* fix: email verification in thirdparty and pless

* fix: email verification

* fix: more test for passwordless

* fix: thirdparty and tests

* fix: remove active user of recipe user when linked (#773)

* fix: remove active user of recipe user when linked

* fix: query

* fix: multitenant user association with account linking (#777)

* fix: test user association

* fix: multitenancy related changes

* fix: pr comments

* fix: pr comments

* fix: merge latest (#782)

* fix: add exp and iat to JWT payloads without scientific notation (#765)

* adding dev-v6.0.9 tag to this commit to ensure building

* fix: fix handling of b64 and b64url encoded access tokens (#767)

* adding dev-v6.0.10 tag to this commit to ensure building

* Update release.md

* Update release.md

* fix: ee featureflag cron job (#778)

* fix: ee featureflag cron job

* fix: test

* fix: tests

* fix: tests

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#779)

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#780)

* fix: test

* fix: test

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#781)

* adding dev-v6.0.11 tag to this commit to ensure building

---------

Co-authored-by: Mihály Lengyel <[email protected]>
Co-authored-by: rishabhpoddar <[email protected]>

* fix: tests (#776)

* fix: tests

* fix: removed removal of active user

* fix: user id mapping deletion

* fix: more fixes

* fix: user delete

* fix: test

* fix: test

* fix: session fix and thirdparty ev test

* fix: pr comments

* fix: pr comments

* fix: tests

* fix: phone number change related

* fix: get user by id as per recipe (#788)

* fix: updated migration (#790)

* fix: updated migration script

* fix: fkey constraint on primary_or_recipe_user_id (#791)

* fix: account linking stats (#792)

* fix: account linking stats

* fix: test

* fix: pr comments

* fix: updated test

* Merge latest 6.0.12 (#795)

* fix: add exp and iat to JWT payloads without scientific notation (#765)

* adding dev-v6.0.9 tag to this commit to ensure building

* fix: fix handling of b64 and b64url encoded access tokens (#767)

* adding dev-v6.0.10 tag to this commit to ensure building

* Update release.md

* Update release.md

* fix: ee featureflag cron job (#778)

* fix: ee featureflag cron job

* fix: test

* fix: tests

* fix: tests

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#779)

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#780)

* fix: test

* fix: test

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#781)

* adding dev-v6.0.11 tag to this commit to ensure building

* Update README.md (#783)

Corrected all the grammatical errors in the README file.

* fix: session concurrency issue (#785)

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: fixing ee folder issue when empty database at startup (#786)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: test (#787)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* fix: test

* adding dev-v6.0.12 tag to this commit to ensure building

* bug fixes

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: remove print

---------

Co-authored-by: Mihály Lengyel <[email protected]>
Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Abhisar Yadav <[email protected]>

* fix: tests for tenant association with unlinked account

* fix: email password update email

* fix: shared user in pless

* fix: recipe user association

* fix: ep login issues

* fix: allow user disassociation from all tenant (#799)

* fix: allow user disassociation from all tenants

* fix: multitenancy

* fix: updated changelog

* fix: rename userId to recipeUserId

* fix: function changes (#802)

* fix: account function changes

* fix: function updates

* fix: link and unlink accounts (#803)

* fix: password reset changes (#804)

* fix: adds recipe user id in session (#805)

* fix: fixes query (#806)

* fix: user pagination (#807)

* fix: multitenant user association (#808)

* fix: remove con reuse (#810)

* fix: index updates (#811)

* fix: fkey constraint (#812)

* fix: account linking stats (#813)

* fix: allow tenant disassociation (#814)

* fix: tests (#815)

* fix: tests

* fix: tests

* fix: license stats fix (#818)

* fix: add exp and iat to JWT payloads without scientific notation (#765)

* adding dev-v6.0.9 tag to this commit to ensure building

* fix: fix handling of b64 and b64url encoded access tokens (#767)

* adding dev-v6.0.10 tag to this commit to ensure building

* Update release.md

* Update release.md

* fix: ee featureflag cron job (#778)

* fix: ee featureflag cron job

* fix: test

* fix: tests

* fix: tests

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#779)

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#780)

* fix: test

* fix: test

* adding dev-v6.0.11 tag to this commit to ensure building

* fix: test (#781)

* adding dev-v6.0.11 tag to this commit to ensure building

* Update README.md (#783)

Corrected all the grammatical errors in the README file.

* fix: session concurrency issue (#785)

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: fixing ee folder issue when empty database at startup (#786)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* adding dev-v6.0.12 tag to this commit to ensure building

* fix: test (#787)

* fix: fixing ee folder issue when empty database at startup

* fix: changelog

* fix: test

* adding dev-v6.0.12 tag to this commit to ensure building

* bug fixes

* adding dev-v6.0.12 tag to this commit to ensure building

* Update README.md

* Update README.md

* fix: stats fix (#816)

* fix: stats fix

* fix: pr comments

* fix: disable for in mem

* fix: pr comments

* adding dev-v6.0.13 tag to this commit to ensure building

---------

Co-authored-by: Mihály Lengyel <[email protected]>
Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Abhisar Yadav <[email protected]>

* fix: fixes for mongo plugin (#817)

* fix: version and changelog

* fix: schema updates

* fix: tests

* fix: tests and fixes

* fix: session tests

* fix: signup 3.0

* fix: misc changes

* fix: paid stats test

---------

Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Mihaly Lengyel <[email protected]>
Co-authored-by: Abhisar Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants