fixes issue with logging memory leak (#726)

Co-authored-by: rishabhpoddar <[email protected]>
supertokens · Jun 19, 2023 · c7ebc57 · c7ebc57
1 parent 94b00f5
commit c7ebc57
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/main/java/io/supertokens/output/Logging.java b/src/main/java/io/supertokens/output/Logging.java
@@ -24,10 +24,10 @@
 import io.supertokens.Main;
 import io.supertokens.ResourceDistributor;
 import io.supertokens.config.Config;
-import io.supertokens.pluginInterface.multitenancy.exceptions.TenantOrAppNotFoundException;
 import io.supertokens.pluginInterface.LOG_LEVEL;
 import io.supertokens.pluginInterface.Storage;
 import io.supertokens.pluginInterface.multitenancy.TenantIdentifier;
+import io.supertokens.pluginInterface.multitenancy.exceptions.TenantOrAppNotFoundException;
 import io.supertokens.storageLayer.StorageLayer;
 import io.supertokens.utils.Utils;
 import io.supertokens.webserver.Webserver;
@@ -174,7 +174,8 @@ public static void error(Main main, TenantIdentifier tenantIdentifier, String er
         }
     }
 
-    public static void error(Main main, TenantIdentifier tenantIdentifier, String message, boolean toConsoleAsWell, Exception e) {
+    public static void error(Main main, TenantIdentifier tenantIdentifier, String message, boolean toConsoleAsWell,
+                             Exception e) {
         try {
             if (!Config.getConfig(new TenantIdentifier(null, null, null), main).getLogLevels(main)
                     .contains(LOG_LEVEL.ERROR)) {
@@ -220,6 +221,10 @@ public static void stopLogging(Main main) {
         if (getInstance(main) == null) {
             return;
         }
+        getInstance(main).infoLogger.getLoggerContext().stop();
+        getInstance(main).errorLogger.getLoggerContext().stop();
+        getInstance(main).infoLogger.getLoggerContext().getStatusManager().clear();
+        getInstance(main).errorLogger.getLoggerContext().getStatusManager().clear();
         getInstance(main).infoLogger.detachAndStopAllAppenders();
         getInstance(main).errorLogger.detachAndStopAllAppenders();
         Webserver.getInstance(main).closeLogger();

diff --git a/src/test/java/io/supertokens/test/multitenant/LoadTest.java b/src/test/java/io/supertokens/test/multitenant/LoadTest.java
@@ -56,7 +56,7 @@ public void beforeEach() {
     }
 
     @Test
-    public void testCreating100StorageLayersUsage()
+    public void testCreating100TenantsAndCheckOnlyOneInstanceOfStorageLayerIsCreated()
             throws InterruptedException {
         String[] args = {"../"};