Skip to content

Commit

Permalink
changes PR template and adds changelog enforcement PR
Browse files Browse the repository at this point in the history
  • Loading branch information
Rishabh committed Jul 23, 2021
1 parent 66be921 commit a765919
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ labels: 'documentation'

## 📚 Documentation

(A clear and concise description of what the issue is.)
Please open an issue https://github.com/supertokens/docs/issues instead.

9 changes: 0 additions & 9 deletions .github/ISSUE_TEMPLATE/question.md

This file was deleted.

28 changes: 17 additions & 11 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,28 @@ Happy contributing!
-->

## Link to a github issue if relevant
## Related issues
- Link to issue1 here
- Link to issue1 here

(Link the github issue here)

## Motivation

(Write your motivation here.)

### Have you read the [Contributing Guidelines on pull requests](https://github.com/supertokens/supertokens-core/blob/master/CONTRIBUTING.md#pull-request)?

(Write your answer here.)
## Summary of change
(A few sentences about this PR)

## Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

## Documentation changes

(If this PR adds or changes functionality, please take some time to point to the relevant documentation that we should update - https://supertokens.io/docs/community/getting-started/installation)
(If relevant, please create a PR in our [docs repo](https://github.com/supertokens/docs), or create a checklist here highlighting the necessary changes)

## Checklist for important updates
- [ ] Changelog has been updated
- [ ] `coreDriverInterfaceSupported.json` file has been updated (if needed)
- [ ] Changes to the version if needed
- In `build.gradle`
- [ ] Had installed and ran the pre-commit hook

## Remaining TODOs for this PR
- [ ] Item1
- [ ] Item2
15 changes: 15 additions & 0 deletions .github/workflows/github-actions-changelog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: "Pull Request Workflow"
on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]

jobs:
# Enforces the update of a changelog file on every pull request
changelog:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: dangoslen/changelog-enforcer@v2
with:
changeLogPath: 'CHANGELOG.md'
skipLabels: 'Skip-Changelog'
Binary file modified cli/jar/cli.jar
Binary file not shown.
Binary file modified downloader/jar/downloader.jar
Binary file not shown.
Binary file modified jar/core-3.4.1.jar
Binary file not shown.

0 comments on commit a765919

Please sign in to comment.