Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for mfa feature and update existing tests #773

Merged
merged 118 commits into from
Dec 21, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

github-actions bot commented Dec 7, 2023

size-limit report 📦

Path Size
lib/build/index.js 16.36 KB (0%)
recipe/session/index.js 17.46 KB (0%)
recipe/session/prebuiltui.js 20.16 KB (0%)
recipe/thirdpartyemailpassword/index.js 30.28 KB (0%)
recipe/thirdparty/index.js 26.87 KB (0%)
recipe/emailpassword/index.js 10.34 KB (0%)
recipe/emailverification/index.js 7.57 KB (0%)
recipe/passwordless/index.js 67.78 KB (0%)
recipe/thirdpartypasswordless/index.js 88.08 KB (0%)
recipe/emailverification/prebuiltui.js 26.25 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 57.16 KB (0%)
recipe/thirdparty/prebuiltui.js 41.13 KB (0%)
recipe/emailpassword/prebuiltui.js 30.23 KB (0%)
recipe/passwordless/prebuiltui.js 116.4 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 144.66 KB (0%)
recipe/multitenancy/index.js 6.41 KB (0%)
recipe/multifactorauth/index.js 8.07 KB (0%)
recipe/multifactorauth/prebuiltui.js 25.86 KB (0%)

Base automatically changed from feat/mfa/totp to feat/mfa/base December 11, 2023 00:00
* ci: add storybook

* ci: update stories after merge

* ci: update&add stories

* refactor: small code-changes to help storybooks build/work right

* docs: fix usesDynamicLoginMethods control in storybooks

* docs: reset uis properly when re-rendering auth page stories

* docs: provide better error reporting in auth page stories

* docs: add separate stories for different button configs in totp

* test: add stories for auth recipe screens

* fix: type fixes and design updates + extended storybook

* test: make tests backward compatible

* fix: fix recipe name in error message

* test: fix enableMFA
@porcellus porcellus merged commit 5b7b0f8 into feat/mfa/base Dec 21, 2023
18 of 25 checks passed
@porcellus porcellus deleted the feat/mfa/tests branch December 21, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants