-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow returning null from getRedirectionURL override #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
rishabhpoddar
suggested changes
Nov 23, 2023
rishabhpoddar
suggested changes
Nov 24, 2023
porcellus
requested changes
Nov 24, 2023
Co-authored-by: Rishabh Poddar <[email protected]>
anku255
commented
Dec 1, 2023
anku255
commented
Dec 1, 2023
4 tasks
rishabhpoddar
suggested changes
Dec 4, 2023
lib/ts/recipe/passwordless/components/features/signInAndUp/index.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/passwordless/components/features/signInAndUp/index.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/passwordless/components/features/signInAndUp/index.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/passwordless/components/features/signInAndUp/index.tsx
Outdated
Show resolved
Hide resolved
rishabhpoddar
suggested changes
Dec 6, 2023
rishabhpoddar
suggested changes
Dec 7, 2023
Co-authored-by: Rishabh Poddar <[email protected]>
Co-authored-by: Rishabh Poddar <[email protected]>
…ionURLContext (#772) * Update userContext type and make it required in internal functions * Add isNewPrimaryUser in GetRedirectionURLContext * PR changes
This was referenced Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR updates
getRedirectionURL
signature to allow returningnull
that would prevent redirection.Related issues
Test Plan
I have written one unit test and added some code in
with-typescript
repo to test the function signature. Also added e2e tests for emailpassword and passwordless signups.Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.someFunc: function () {..}
).size-limit
section ofpackage.json
with the size limit set to the current size rounded up.rollup.config.mjs
Remaining TODOs for this PR