Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom logo property on thirdparty custom providers #741

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

Chakravarthy7102
Copy link
Contributor

@Chakravarthy7102 Chakravarthy7102 commented Sep 22, 2023

Summary of change

Adds logo property on Thirdparty Custom providers.

Related issues

Test Plan

Manually testing with an example app.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

  • Need to add this newly added logo property in custom providers docs

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

size-limit report 📦

Path Size
lib/build/index.js 14.18 KB (0%)
recipe/session/index.js 15.14 KB (0%)
recipe/session/prebuiltui.js 17.76 KB (0%)
recipe/thirdpartyemailpassword/index.js 29.41 KB (+0.04% 🔺)
recipe/thirdparty/index.js 26.19 KB (+0.04% 🔺)
recipe/emailpassword/index.js 9.94 KB (0%)
recipe/emailverification/index.js 7.26 KB (0%)
recipe/passwordless/index.js 63.47 KB (0%)
recipe/thirdpartypasswordless/index.js 83.95 KB (+0.02% 🔺)
recipe/emailverification/prebuiltui.js 22.45 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 53.57 KB (+0.02% 🔺)
recipe/thirdparty/prebuiltui.js 38.26 KB (+0.03% 🔺)
recipe/emailpassword/prebuiltui.js 27.51 KB (0%)
recipe/passwordless/prebuiltui.js 102.75 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 130.14 KB (+0.01% 🔺)
recipe/multitenancy/index.js 6.12 KB (0%)

@Chakravarthy7102 Chakravarthy7102 changed the base branch from master to 0.35 September 22, 2023 06:41
@Chakravarthy7102 Chakravarthy7102 changed the title feat: add custom logo property on custom providers feat: add custom logo property on thirdparty custom providers Sep 22, 2023
@Chakravarthy7102 Chakravarthy7102 requested review from porcellus and removed request for nkshah2 September 25, 2023 06:08
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but we should add a test for it.
Please check if you can add a unit test that checks that this logo is applied.

@rishabhpoddar rishabhpoddar merged commit 0ad878b into 0.35 Sep 26, 2023
19 of 22 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/add-custom-property branch September 26, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants