Skip to content

Commit

Permalink
fix: the error prop updates in override components (#842)
Browse files Browse the repository at this point in the history
* fix: error prop memoization

* chore: update version number
  • Loading branch information
porcellus authored Jul 31, 2024
1 parent cadb778 commit f926543
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Updated the font and font-weights in the default styles
- We no longer load the Rubik font by default

### Fixes

- Now the error prop should be updated in override components.

## [0.44.0] - 2024-07-15

- Removes the default `maxAgeInSeconds` value (previously 300 seconds) in EmailVerification Claim. If the claim value is true and `maxAgeInSeconds` is not provided, it will not be refreshed.
Expand Down
4 changes: 2 additions & 2 deletions lib/build/emailpasswordprebuiltui.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/build/thirdpartyprebuiltui.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export function useChildProps(
onForgotPasswordClick: onForgotPasswordClick,
userContext,
};
}, [recipe]);
}, [recipe, error, userContext]);
}

export const SignInFeature: React.FC<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export function useChildProps(
onError,
clearError,
};
}, [recipe]);
}, [recipe, error, userContext]);
}

export const SignUpFeature: React.FC<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function useChildProps(
navigate,
userContext,
};
}, [recipe, recipeImplementation]);
}, [recipe, recipeImplementation, error, userContext]);
}

type PropType = PartialAuthComponentProps & {
Expand Down

0 comments on commit f926543

Please sign in to comment.