fix: add missing param

supertokens · Dec 14, 2023 · f75c9b3 · f75c9b3
1 parent d9f812a
commit f75c9b3
Show file tree

Hide file tree

Showing 11 changed files with 30 additions and 18 deletions.
diff --git a/examples/for-tests-react-16/src/App.js b/examples/for-tests-react-16/src/App.js
@@ -506,7 +506,7 @@ export function DashboardHelper({ redirectOnLogout, ...props } = {}) {
             <a
                 className="goToFactorChooser"
                 onClick={() => {
-                    return MultiFactorAuth.redirectToFactorChooser(true, props.history);
+                    return MultiFactorAuth.redirectToFactorChooser(true, undefined, props.history);
                 }}>
                 MFA chooser
             </a>

diff --git a/examples/for-tests/src/App.js b/examples/for-tests/src/App.js
@@ -658,7 +658,7 @@ export function DashboardHelper({ redirectOnLogout, ...props } = {}) {
             <a
                 className="goToFactorChooser"
                 onClick={() => {
-                    return MultiFactorAuth.redirectToFactorChooser(true, props.history);
+                    return MultiFactorAuth.redirectToFactorChooser(true, undefined, props.history);
                 }}>
                 MFA chooser
             </a>

diff --git a/lib/build/multifactorauthprebuiltui.js b/lib/build/multifactorauthprebuiltui.js
diff --git a/lib/build/passwordless-shared4.js b/lib/build/passwordless-shared4.js
diff --git a/lib/build/totpprebuiltui.js b/lib/build/totpprebuiltui.js
diff --git a/lib/ts/recipe/multifactorauth/components/features/factorChooser/index.tsx b/lib/ts/recipe/multifactorauth/components/features/factorChooser/index.tsx
@@ -77,6 +77,7 @@ export const FactorChooser: React.FC<Prop> = (props) => {
                 return MultiFactorAuth.getInstanceOrThrow().redirectToFactor(
                     availableFactors[0].id,
                     false,
+                    false,
                     props.history
                 );
             } else {

diff --git a/lib/ts/recipe/passwordless/components/features/mfa/index.tsx b/lib/ts/recipe/passwordless/components/features/mfa/index.tsx
@@ -203,7 +203,7 @@ export function useChildProps(
                 return history(-1);
             },
             onFactorChooserButtonClicked: () => {
-                return MultiFactorAuth.getInstanceOrThrow().redirectToFactorChooser(false, history);
+                return MultiFactorAuth.getInstanceOrThrow().redirectToFactorChooser(false, undefined, history);
             },
             recipeImplementation: recipeImplementation,
             config: recipe.config,

diff --git a/lib/ts/recipe/totp/components/features/mfa/index.tsx b/lib/ts/recipe/totp/components/features/mfa/index.tsx
@@ -252,7 +252,7 @@ export function useChildProps(
                 await redirectToAuth({ redirectBack: false, history: history });
             },
             onFactorChooserButtonClicked: () => {
-                return MultiFactorAuth.getInstanceOrThrow().redirectToFactorChooser(false, history);
+                return MultiFactorAuth.getInstanceOrThrow().redirectToFactorChooser(false, undefined, history);
             },
             onSuccess: () => {
                 const redirectToPath = getRedirectToPathFromURL();

diff --git a/test/exampleTestHelpers.js b/test/exampleTestHelpers.js
@@ -125,10 +125,7 @@ function getTestPhoneNumber() {
 }
 
 async function getSignInOrSignUpSwitchLink(page) {
-    return waitForSTElement(
-        page,
-        "div > div > [data-supertokens~='headerSubtitle'] > div > [data-supertokens~='link']"
-    );
+    return waitForSTElement(page, "div > div > [data-supertokens~='headerSubtitle'] > [data-supertokens~='link']");
 }
 
 async function toggleSignInSignUp(page) {
@@ -137,6 +134,13 @@ async function toggleSignInSignUp(page) {
     await signUpLink.click();
 }
 
+async function chooseFactor(page, id) {
+    const ele = await waitForSTElement(page, `[data-supertokens~=factorChooserOption][data-supertokens~=${id}]`);
+    await new Promise((res) => setTimeout(res, 100));
+    await Promise.all([page.waitForNavigation({ waitUntil: "networkidle0" }), ele.click()]);
+    await waitForSTElement(page);
+}
+
 module.exports = {
     waitForSTElement,
     getSubmitFormButton,
@@ -149,4 +153,5 @@ module.exports = {
     getTestPhoneNumber,
     getSignInOrSignUpSwitchLink,
     toggleSignInSignUp,
+    chooseFactor,
 };
diff --git a/test/helpers.js b/test/helpers.js
@@ -171,10 +171,7 @@ export async function getLogoutButton(page) {
 }
 
 export async function getSignInOrSignUpSwitchLink(page) {
-    return waitForSTElement(
-        page,
-        "div > div > [data-supertokens~='headerSubtitle'] > div > [data-supertokens~='link']"
-    );
+    return waitForSTElement(page, "div > div > [data-supertokens~='headerSubtitle'] > [data-supertokens~='link']");
 }
 
 export async function getForgotPasswordLink(page) {

diff --git a/test/visual/basic.test.js b/test/visual/basic.test.js
@@ -133,7 +133,7 @@ describe("Visual testing", function () {
             ]);
             await page.waitForSelector("[data-supertokens~='headerSubtitle']");
             // Switch to sign up
-            await page.click("[data-supertokens~='headerSubtitle'] > div > [data-supertokens~='link']");
+            await page.click("[data-supertokens~='headerSubtitle'] > [data-supertokens~='link']");
             await snapshot(page, "empty");
 
             await setInputValue(page, { name: "email", value: "[email protected]" });
@@ -170,7 +170,7 @@ describe("Visual testing", function () {
             ]);
             await page.waitForSelector("[data-supertokens~='headerSubtitle']");
             // Switch to sign up
-            await page.click("[data-supertokens~='headerSubtitle'] > div > [data-supertokens~='link']");
+            await page.click("[data-supertokens~='headerSubtitle'] > [data-supertokens~='link']");
 
             await setInputValue(page, { name: "email", value: "[email protected]" });
             await setInputValue(page, { name: "password", value: "weak" });
@@ -622,7 +622,7 @@ describe("Visual testing", function () {
             ]);
             await page.waitForSelector("[data-supertokens~='headerSubtitle']");
             // Switch to sign up
-            await page.click("[data-supertokens~='headerSubtitle'] > div > [data-supertokens~='link']");
+            await page.click("[data-supertokens~='headerSubtitle'] > [data-supertokens~='link']");
             await snapshot(page, "empty");
 
             await setInputValue(page, { name: "email", value: "[email protected]" });
@@ -659,7 +659,7 @@ describe("Visual testing", function () {
             ]);
             await page.waitForSelector("[data-supertokens~='headerSubtitle']");
             // Switch to sign up
-            await page.click("[data-supertokens~='headerSubtitle'] > div > [data-supertokens~='link']");
+            await page.click("[data-supertokens~='headerSubtitle'] > [data-supertokens~='link']");
 
             await setInputValue(page, { name: "email", value: "[email protected]" });
             await setInputValue(page, { name: "password", value: "weak" });