fix: use twitter as twitter providers Id (#746)

* fix: use twitter as twitter providers Id * update changelog and bump version * update changelog * incorporate suggested changes * update code
supertokens · Sep 28, 2023 · be1dcc1 · be1dcc1
1 parent 3d1cabf
commit be1dcc1
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 -   Updated dev/start script in netlify example
 
+## [0.35.4] - 2023-09-28
+
+### Fixes
+
+-   fixed using `twitter` as id by default in twitter provider.
+
 ## [0.35.3] - 2023-09-26
 
 ### Added

diff --git a/lib/build/thirdparty-shared.js b/lib/build/thirdparty-shared.js
diff --git a/lib/build/version.d.ts b/lib/build/version.d.ts
diff --git a/lib/ts/recipe/thirdparty/providers/twitter.tsx b/lib/ts/recipe/thirdparty/providers/twitter.tsx
@@ -39,17 +39,16 @@ export default class Twitter extends Provider {
      * Constructor.
      */
     constructor(config?: TwitterProviderConfig) {
-        let id = "x";
         let name = "X";
+
         const normalisedUseLegacyTwitterLogo = config?.useLegacyTwitterLogo === true;
 
         if (normalisedUseLegacyTwitterLogo) {
-            id = "twitter";
             name = "Twitter";
         }
 
         super({
-            id,
+            id: "twitter",
             name,
             ...config,
         });

diff --git a/lib/ts/version.ts b/lib/ts/version.ts
@@ -12,4 +12,4 @@
  * License for the specific language governing permissions and limitations
  * under the License.
  */
-export const package_version = "0.35.3";
+export const package_version = "0.35.4";
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "supertokens-auth-react",
-    "version": "0.35.3",
+    "version": "0.35.4",
     "description": "ReactJS SDK that provides login functionality with SuperTokens.",
     "main": "./index.js",
     "engines": {