test: backport stability fixes (#826)

* test: improve test stability * chore: update version number
supertokens · May 28, 2024 · 4d43284 · 4d43284
1 parent 3ff5d6d
commit 4d43284
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+## [0.41.2] - UNRELEASED
+
+### Test changes
+
+-   Backported some test stability fixes
+
 ## [0.41.1] - 2024-05-13
 
 ### Fixes

diff --git a/lib/build/genericComponentOverrideContext.js b/lib/build/genericComponentOverrideContext.js
diff --git a/lib/build/version.d.ts b/lib/build/version.d.ts
diff --git a/lib/ts/version.ts b/lib/ts/version.ts
@@ -12,4 +12,4 @@
  * License for the specific language governing permissions and limitations
  * under the License.
  */
-export const package_version = "0.41.1";
+export const package_version = "0.41.2";
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "supertokens-auth-react",
-    "version": "0.41.1",
+    "version": "0.41.2",
     "description": "ReactJS SDK that provides login functionality with SuperTokens.",
     "main": "./index.js",
     "engines": {

diff --git a/test/end-to-end/multitenancy.dynamic_login_methods.test.js b/test/end-to-end/multitenancy.dynamic_login_methods.test.js
@@ -229,9 +229,14 @@ describe("SuperTokens Multitenancy dynamic login methods", function () {
 
     it("should postpone render with no react-router-dom", async function () {
         await page.setRequestInterception(true);
-        const requestHandler = (request) => {
+        let resolveLoginMethodsReq;
+        const loginMethodsReqPromise = new Promise((res) => {
+            resolveLoginMethodsReq = res;
+        });
+        const requestHandler = async (request) => {
             if (request.url().startsWith(LOGIN_METHODS_API)) {
-                setTimeout(() => request.continue(), 500);
+                await loginMethodsReqPromise;
+                request.continue();
             } else {
                 request.continue();
             }
@@ -249,7 +254,7 @@ describe("SuperTokens Multitenancy dynamic login methods", function () {
 
         const spinner = await waitForSTElement(page, "[data-supertokens~=delayedRender]");
         assert.ok(spinner);
-        await page.waitForTimeout(2000);
+        resolveLoginMethodsReq();
         const providers = await getProvidersLabels(page);
         compareArrayContents(providers, ["Continue with Apple"]);
     });

diff --git a/test/helpers.js b/test/helpers.js
@@ -120,7 +120,7 @@ export async function getSubmitFormButtonLabel(page) {
 }
 
 export async function getProvidersLabels(page) {
-    await waitForSTElement(page);
+    await waitForSTElement(page, "[data-supertokens~=headerTitle]");
     return await page.evaluate(
         ({ ST_ROOT_SELECTOR }) =>
             Array.from(