Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Problem Statement
This PR fixes the issues found in the tenant management section of the dashboard. All issues are highlighted here
Summary of solution
Dialog component
closeOnOverlayClick
prop has been changed totrue
. This change will cause all overlays to close by default when the body of the screen is clicked.lockScroll
has been added to determine whether body scroll should be locked when dialog is open, true by default.UI fixes
100vw
width style has been removedRelated issues
Test Plan
Tested on all primary browsers for:
Feature tests:
Dashboard Admin access.
POST
,PUT
andDELETE
endpoints with admins only access enabled for the dashboard recipe.POST
,PUT
andDELETE
endpoints without the admins only access enabled.Search
General UI testing
Multi tenant testing
User Roles and Permissions testing
feature_not_enabled
state on both userDetails page and user roles page.User creation
emailpassword
andthirdpartyemailpassword
together and individually.passwordless
andthirdpartypasswordless
together and individually.contactMethod
's ensure that the frontend displays relevant UI based on thecontactMethod
selected.emailpassword
andpasswordless
user with the same email and make sure that the accounts are linked.User details
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
package.json
package-lock.json
src/version.ts
npm run build
Remaining TODOs for this PR