-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: User creation from dashboard. #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: API spec for user creation on user dashboard
Chakravarthy7102
changed the title
Feat/user creation
feat: User creation from dashboard.
Dec 12, 2023
rishabhpoddar
suggested changes
Dec 22, 2023
rishabhpoddar
suggested changes
Dec 28, 2023
Chakravarthy7102
force-pushed
the
feat/user-creation
branch
from
December 28, 2023 14:10
c7ea1f5
to
ed8ba36
Compare
rishabhpoddar
suggested changes
Jan 3, 2024
rishabhpoddar
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Summary of change
TODO
Adds ability to create users from user management dashboard.
Summary of solution
(Overview of how the problem is solved by this PR)
Related issues
Test Plan
Tested on all primary browsers for:
Feature tests:
feature_not_enabled
state on both userDetails page and user roles page.Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
package.json
package-lock.json
src/version.ts
npm run build
Remaining TODOs for this PR