-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API spec for user creation on user dashboard #127
Conversation
api_spec.yaml
Outdated
- type: object | ||
properties: | ||
methodType: | ||
type: string | ||
default: "passwordless" | ||
contactMethod: | ||
type: string | ||
enum: [PHONE, EMAIL, EMAIL_OR_PHONE] | ||
- type: object | ||
properties: | ||
methodType: | ||
type: string | ||
default: "emailPassword" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is third party (add it even though it won't be used, cause the API semantics imply give me all login methods that are enabled for this tenant...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
api_spec.yaml
Outdated
- type: object | ||
properties: | ||
methodType: | ||
type: string | ||
default: "passwordless" | ||
contactMethod: | ||
type: string | ||
enum: [PHONE, EMAIL, EMAIL_OR_PHONE] | ||
- type: object | ||
properties: | ||
methodType: | ||
type: string | ||
default: "emailPassword" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- type: object | |
properties: | |
methodType: | |
type: string | |
default: "passwordless" | |
contactMethod: | |
type: string | |
enum: [PHONE, EMAIL, EMAIL_OR_PHONE] | |
- type: object | |
properties: | |
methodType: | |
type: string | |
default: "emailPassword" | |
- type: object | |
properties: | |
methodType: | |
type: string | |
default: "passwordless" | |
contactMethod: | |
type: string | |
enum: [PHONE, EMAIL, EMAIL_OR_PHONE] | |
- type: object | |
properties: | |
methodType: | |
type: string | |
default: "emailpassword" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Summary of change
Adds api spec for creating of users with different login methods like emailpassword, thirdparty and passwordless login from user management dashboard.
Related issues
Test Plan
Tested on all primary browsers for:
Feature tests:
feature_not_enabled
state on both userDetails page and user roles page.Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
package.json
package-lock.json
src/version.ts
npm run build
Remaining TODOs for this PR