Integrate with StructureManagerWidget from AiiDAlab-Widget-Base. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
force-pushed
the
feature/integrate-with-structuremanager-widget
branch
from
5f4722c
to
d5776fb
Compare
|
@yakutovicha now the viewer should update when updating the atoms. Please try. |
Add tests: - generate documentation - pure python test using pytest - notebook test using yarn and playwright, check the official document from ipywidgets
Add tests: - generate documentation - pure python test using pytest - notebook test using yarn and playwright, check the official document from ipywidgets
superstar54
force-pushed
the
main
branch
3 times, most recently
from
eafb7af
to
d3846a3
Compare
weas and weas-widget are separate repos, but if we want to debug/develop a new feature of weas for the widget, using bundling makes the development more convenient. The js code was moved to the `js` folder, run `npm run build-watch` will bundle these assets into the `src/weas_widget/static` folder, and watch the changes. ## Use local weas If we want to use the weas package, then clone the weas repo, and the two repo folders are in the same level. ## Use release weas version If we want to use the release version from unpkg ## Publish Python package - Use the release version - run `npm run build` - python -m build - twine upload dist/*
superstar54
force-pushed
the
main
branch
2 times, most recently
from
f2b59f9
to
dd5159c
Compare
viewer.cameraSetting = {"direction": [0, 2, 1], "zoom": 0.8}
superstar54
force-pushed
the
main
branch
7 times, most recently
from
5390c05
to
43d39f7
Compare
superstar54
force-pushed
the
feature/integrate-with-structuremanager-widget
branch
from
7119b9f
to
f1acf57
Compare
superstar54
force-pushed
the
feature/integrate-with-structuremanager-widget
branch
from
f1acf57
to
0f90bc3
Compare
superstar54
force-pushed
the
feature/integrate-with-structuremanager-widget
branch
from
0f90bc3
to
52f5b7d
Compare
superstar54
changed the title
manzt
reviewed
Mar 18, 2024
js/widget.css
Outdated
Comment on lines
86
to
88
| select { | ||
| color: black !important; /* Or any color that provides better contrast */ | ||
| } |
There was a problem hiding this comment.
This will restyle all select elements on the entire page (probably not what you want, especially if others use sliders like ipywidgets). To scope these styles to just elements added by this widget, I'd recommend adding a class to the root el in render and applying a selector for select here:
function render({ model, el }) {
/* ... */
el.classList.add("weas-widget");
el.appendChild(...);
}.weas-widget > select {
color: black;
}There was a problem hiding this comment.
(Sorry, just passing by as I saw a mention of anywidget. Had a look at PRs to see the api usage. Feel free to ignore my unsolicited suggestion!)
There was a problem hiding this comment.
@manzt , thank you so much for taking the time to review and offer your suggestion! I've implemented the changes based on your advice. Your insight was incredibly helpful, and I appreciate it. If you have any more suggestions or feedback not only for this PR, but the widget, please feel free to share.
superstar54
force-pushed
the
main
branch
5 times, most recently
from
619a418
to
504f042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.