extract PDF bookmark with priority #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexis-
requested changes
Mar 12, 2020
| { | ||
| PDFElement pdfEl; | ||
| string title; | ||
| string author; | ||
| string creationDate; | ||
| string filePath; | ||
|
|
||
|
|
||
| if (priority < 0 || priority > 100) |
There was a problem hiding this comment.
Good call. Can you also add a LogTo.Error(...) message since this should never happen ? That way a bug report will be sent if it does happen
PDF/PDFWindow.xaml.cs
Outdated
| return; | ||
| } | ||
|
|
||
| IPDFViewer.ExtractBookmark(bookmark, result.Model.Value); |
There was a problem hiding this comment.
Can you add a check for the Priority value provided by the user, like in your other Extract with priority PR ?
There was a problem hiding this comment.
OK. I added a check and included an Alert window if the priority value is invalid.
PDF/Viewer/IPDFViewer.SuperMemo.cs
Outdated
| @@ -225,7 +225,7 @@ protected ContentBase CreateImageContent(Image image, string title) | |||
|
|
|||
| // PDF Extracts | |||
|
|
|||
| protected bool CreatePDFExtract() | |||
| protected bool CreatePDFExtract(double priority = -1) | |||
There was a problem hiding this comment.
Sorry, I think I added that by mistake. I removed it in the latest commit.
|
Looks like there are some conflicts. Could you take a look whenever you have a moment ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to extract a bookmark from a PDF and specify the priority in a popup window.
There's also a menu item: