[SW-737, SW-765] AirGap Integration #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
4 times, most recently
from
a1ab762 to
35dc133
Compare
konradodo
reviewed
Feb 20, 2023
konradodo
reviewed
Feb 20, 2023
konradodo
reviewed
Feb 20, 2023
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
4 times, most recently
from
64eac5a to
34b0914
Compare
|
Deployed to feature-mvp-qr-based-wallet.wallet.z52da5wt.xyz, artifacts |
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
7 times, most recently
from
012b868 to
9d243c2
Compare
ifaouibadi
changed the title
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
9d243c2 to
f800b62
Compare
ifaouibadi
requested review from
peronczyk,
pstachel,
CedrikNikita and
subhod-i
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
3 times, most recently
from
4ba9d99 to
7de8de0
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
7de8de0 to
ce7c67e
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
76a65b1 to
57cbae0
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
57cbae0 to
58d3038
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
3 times, most recently
from
9f981fa to
b5f132f
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
4 times, most recently
from
7ef505e to
ba30bae
Compare
subhod-i
reviewed
May 11, 2023
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
2 times, most recently
from
9b36194 to
6067e9d
Compare
konradodo
reviewed
May 16, 2023
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
2 times, most recently
from
e63779e to
9f28f73
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
9f28f73 to
eea2955
Compare
|
I'd like to integrate this on sdk side, it is still blocked by AirGap? |
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
3fe708f to
9ca4aa0
Compare
ifaouibadi
force-pushed
the
feature/mvp-qr-based-wallet
branch
from
2d21a8e to
31b6774
Compare
@davidyuk Currently AirgGapVault deep link redirection is hard-coded to AirGapWallet. we will go with only QR code-based transaction signing for this PR |
|
closing in favor of #2983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1Screen.Recording.2023-03-30.at.12.38.52.mov