Suggestion to the PR about add React and Vue components #39
Conversation
shapkarin
force-pushed
the
feature/vue-and-react-versions
branch
from
43622c0 to
0c49ed9
Compare
shapkarin
force-pushed
the
feature/suggestions_to_pr_38
branch
from
eea8567 to
e91981a
Compare
shapkarin
force-pushed
the
feature/suggestions_to_pr_38
branch
from
e91981a to
c87d8bc
Compare
| @@ -26,6 +25,20 @@ version for React or Vue by importing `dist/react-without-styles.js` or | |||
| `dist/vue-without-styles.js` accordingly. The framework-specific version contains | |||
| all features available in the default one plus specific for particular framework wrappers. | |||
|
|
|||
| ### Develop | |||
There was a problem hiding this comment.
I agree that this was not covered well, but have you noticed a similar section at the end of readme? I'm proposing to update it instead in a2aa925
There was a problem hiding this comment.
yes, I saw that later after this commit
| display: -ms-flexbox; | ||
| display: -webkit-flex; | ||
| display: flex; | ||
| -webkit-flex-direction: column; |
There was a problem hiding this comment.
Don't vue cli has autoprefixer enabled by default?
There was a problem hiding this comment.
I will remove prefixes
There was a problem hiding this comment.
I don't think that we need prefixes in sites for developers at all.
| @@ -15,3 +20,30 @@ export default { | |||
| }, | |||
| } | |||
| </script> | |||
|
|
|||
| <style> | |||
| .Example-List { | |||
There was a problem hiding this comment.
These styles are duplicated, doesn't look good
There was a problem hiding this comment.
Right, needs to be combined to keep all examples the same
| <SuperheroButton size="medium" account="ak_... or .chain name" /> | ||
|
|
||
| {['large', 'small', 'icon'].map(size => |
There was a problem hiding this comment.
I think the initial example is fine, and we shouldn't spend any more time working on this. The purpose of building these examples was to ensure that our button is compatible with different use cases.
There was a problem hiding this comment.
I think that until we don't have any tests, it will be useful to render as much possible variances as we can, to make it easier to check if something is wrong.
davidyuk
force-pushed
the
master
branch
5 times, most recently
from
22c4bb6 to
f1e1731
Compare
suggestions to the PR #38