Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when publish step should happen #103

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix when publish step should happen #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36c87c
chore: fix when publish step should happen
freaz Sep 4, 2023
373e9a7
chore(ci/cd): update package.json version
freaz Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
# when host-python is skipped this job should still run if inputs allow
# so we need to include a status check, then manually ensure core build didn't fail
# (see https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions)
if: ${{ !cancelled() && (needs.core.result == 'success') && (inputs.host == 'js' || inputs.host == 'all') }}
if: ${{ !cancelled() && needs.core.result == 'success' && (inputs.host == 'js' || inputs.host == 'all') }}
runs-on: ubuntu-latest
outputs:
RELEASE_VERSION: ${{ steps.release-version.outputs.RELEASE_VERSION }}
Expand Down Expand Up @@ -122,6 +122,10 @@ jobs:
- name: Resolve release version
id: release-version
run: scripts/release-version.sh ./host/javascript/VERSION ${{ steps.release-level.outputs.RELEASE_LEVEL }} ${{ steps.release-level.outputs.RELEASE_PREID }} >>$GITHUB_OUTPUT
# Update version
- name: Update version in package.json
working-directory: host/python
run: yarn version --no-git-tag-version --new-version ${{ steps.release-version.outputs.RELEASE_VERSION }}
# Build
- uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -187,7 +191,7 @@ jobs:
host-javascript-publish:
name: Publish JavaScript Host
needs: [core, host-javascript-prepare]
if: ${{ inputs.host == 'js' || inputs.host == 'all' }}
if: ${{ !cancelled() && needs.host-javascript-prepare.result == 'success' }}
runs-on: ubuntu-latest
steps:
# Setup
Expand Down Expand Up @@ -245,7 +249,7 @@ jobs:
# Update version
- name: Update version in pyproject
working-directory: host/python
run: toml set --toml-path pyproject.toml project.version ${{ steps.release-version.outputs.RELEASE_VERSION }}
run: toml set --toml-path pyproject.toml project.version ${{ steps.release-version.outputs.RELEASE_VERSION }}
# Build
- uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -307,7 +311,7 @@ jobs:
host-python-publish:
name: Publish Python Host
needs: [core, host-python-prepare]
if: ${{ inputs.host == 'python' || inputs.host == 'all' }}
if: ${{ !cancelled() && needs.host-python-prepare.result == 'success' }}
runs-on: ubuntu-latest
steps:
# Setup
Expand Down