Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faq.md | changed wording around prepared statements in FAQ #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheOtherBrian1
Copy link

What kind of change does this PR introduce?

doc update

What is the current behavior?

Supavisor in transaction mode does not support standard prepared statements, but the documentation claims otherwise.

What is the new behavior?

Updated the FAQ

Additional context

The docs state:

As of 1.0 Supavisor supports prepared statements. Supavisor will detect
prepare statements and issue those to all database connections. All clients
will then be able to address those prepared statements by name when issuing
execute statements.

Prepared statements are not fully supported and this claim caused user confusion (ticket). It's worthwhile to add more context or remove the claim.

It's also worth re-opening up issue #69

@TheOtherBrian1 TheOtherBrian1 requested a review from a team as a code owner November 3, 2024 19:01
@TheOtherBrian1 TheOtherBrian1 changed the title Update faq.md | session mode doc update Update faq.md | changed wording around prepared statements in FAQ Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants