fix(auth): URLError coercion for RetryableError causing session to be deleted
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
reviewed
Nov 11, 2024
grdsdev
changed the title
RetryableError causing session to be deleted
grdsdev
changed the title
RetryableError causing session to be deletedURLError coercion for RetryableError causing session to be deleted
grdsdev
force-pushed
the
stephen/fix-url-error-coercion
branch
from
777b5b5
to
32022e1
Compare
grdsdev
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes the issue described in #596
What is the current behavior?
URLErrorare retried or any error that directly conforms toRetryableErrorWhat is the new behavior?
NSErrororErrorthat conforms toURLErrorand is retryable will be retried along with any error that directly conforms toRetryableError