-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pg_repack 1.5.2: Allow to run pg_repack by non-superuser #1314
Conversation
New version allows to run pg_repack by a non-superuser. PR on pg_repack repo: reorg/pg_repack#431
519f48e
to
1ec6986
Compare
@@ -13,7 +13,7 @@ | |||
git: | |||
repo: https://github.com/reorg/pg_repack.git | |||
dest: /tmp/pg_repack | |||
version: "ver_{{ pg_repack_release }}" | |||
version: "{{ pg_repack_commit }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is this ansible file still used for postgres extensions? I thought we only do the Nix change nowadays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. Indeed, I wasn't sure if it was necessary. I reverted that change. I also bumped postgres release, it seems it is necessary to do on bumping an extension version.
Oh, I see there's already a test upstream. Nevermind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What kind of change does this PR introduce?
pg_repack
from1.5.0
to1.5.2
.Additional context
New version will allow to run
pg_repack
by a non-superuser. Conversation on slack:https://supabase.slack.com/archives/C02FHG9QQAF/p1730124043199329
PR on
pg_repack
repo:reorg/pg_repack#431
1.5.2
doesn't have release or tag yet, therefore instead of the tag commit id is used (85b64c6d4f599b2988343c4e7121acab505c9006
).Action Items
Extensions compatibility testing
pg_net
- execute HTTP requestspg_graphql
- execute queries and mutationsBackup Testing
Follow the testing steps steps for all the following cases:
Testing steps
supa db-stats gather -p <project_ref>
supa db-stats verify
against the project and the previously saved file