Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sam/oriole17 #1298

Merged
merged 121 commits into from
Nov 25, 2024
Merged

Sam/oriole17 #1298

merged 121 commits into from
Nov 25, 2024

Conversation

samrose
Copy link
Contributor

@samrose samrose commented Oct 25, 2024

What kind of change does this PR introduce?

A draft PR to work out the build, test and deploy of orioledb pg17 with extensions that are compatible

samrose and others added 30 commits October 7, 2024 16:28
* fix: reformat ec2 cleanup commands (#1267)

Co-authored-by: Sam Rose <[email protected]>

* feat: build and flake check of pg 16.3 with exts/wrappers

* pg_partman test 15/16 compat

* merge sql interface test

* tests: build test and cache both versions

* chore: run checks individually

* feat: realease 15 and 16 to staging

* chore: update versions

* chore: make yq available

* chore: run yq from nix

* chore: more setup for staging AMI

* fix: yq usage

* chore: shell vars

* fix: When --init none is used, only users who can elevate to sudo privileges can run Nix

* fix: no -i

* fix: quote correction

* fix: newline extra quotes

* fix: no need for pg major version on packer

* fix: postgresql_major

* fix: ql

* fix: no ansible args in stage to invocation

* fix: unique val

* fix: adjustments to build scripts

* chore: env var handling

* fix: bump to build

* chore: set up more required vars

* chore: bump var

* feat: pg 16 debug symbols

* feat: matrix pg versions build on testinfra

* feat: matrix on Test Database

* chore: running nix in the right context

* feat: just use existing Dockerfile + pg version

* chore: refer to var

* fix: read name without including quotes

* chore: try format function

* fix: strip quotes from version number

* chore: env var

* fix: pg client

* fix

* fix: try to use psql from our own corresponding pkg

* fix: try psql from ppa

* fix: dbmate per pg version

* build dbmate and then install client

* fix: account for architecture

* chore: limit changes detection migrations/schema.sql

* missing docker compose call

* ore: drop tests while investigating

* test: try on pg15 only

* chore: schema needs update

* chore: now run on all versions in matrix

* test: trying a version of schema per major pg version as there are type diffs

---------

Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: Oliver Rice <[email protected]>
create a matrix build for 15 16 (or how ever many versions there are)
@samrose samrose marked this pull request as ready for review November 21, 2024 17:03
fi

cd ..
'';

buildAndTestSubdir = "wrappers";
buildFeatures = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can replace this with all_fdws so that they get pulled in automatically as they're added, rather than us ensuring that newly introduced are covered - https://github.com/supabase/wrappers/blob/main/wrappers/Cargo.toml#L157-L160

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcnc if it's ok with you I will follow up with a PR to do this rather than on this one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sounds good!

docker/nix/build_nix.sh Outdated Show resolved Hide resolved
@samrose samrose requested a review from pcnc November 25, 2024 10:57
@samrose samrose merged commit 897d9f3 into develop Nov 25, 2024
13 checks passed
@samrose samrose deleted the sam/oriole17 branch November 25, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants