Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enabled flag for functions under config.toml #2688

Merged
merged 9 commits into from
Sep 18, 2024
Merged

feat: add enabled flag for functions under config.toml #2688

merged 9 commits into from
Sep 18, 2024

Conversation

avallete
Copy link
Member

@avallete avallete commented Sep 16, 2024 •
edited
Loading

What kind of change does this PR introduce?

This PR add the capability of having a no_deploy flag under the config.toml [fuctions.] allowing to exclude some functions from the deployment.

Fixes #1507

What is the current behavior?

What is the new behavior?

Additional context

Documentation added here: supabase/supabase#29340

@coveralls
Copy link

coveralls commented Sep 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10919699308

Details

  • 19 of 22 (86.36%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 60.125%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/deploy/deploy.go 17 18 94.44%
internal/functions/serve/serve.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10906397868: 0.006%
Covered Lines: 6455
Relevant Lines: 10736
💛 - Coveralls

sweatybridge
sweatybridge reviewed Sep 17, 2024
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@avallete avallete mentioned this pull request Sep 17, 2024
Closed
@avallete avallete marked this pull request as ready for review September 17, 2024 09:54
@avallete avallete requested a review from a team as a code owner September 17, 2024 09:54
@avallete avallete changed the title feat: add no-deploy flag for functions under config.toml feat: add enabled flag for functions under config.toml Sep 17, 2024
sweatybridge
sweatybridge approved these changes Sep 18, 2024
View reviewed changes
internal/functions/deploy/deploy.go Outdated Show resolved Hide resolved
internal/functions/serve/serve.go Outdated Show resolved Hide resolved
avallete added a commit to supabase/supabase that referenced this pull request Sep 18, 2024
@avallete
chore: document atomic function.enabled config flag
1b73eec 
Related: supabase/cli#2688
@avallete avallete mentioned this pull request Sep 18, 2024
Merged
@avallete avallete merged commit 7ec843d into supabase:develop Sep 18, 2024
9 checks passed
avallete added a commit to supabase/supabase that referenced this pull request Sep 18, 2024
@avallete
chore: document atomic function.enabled config flag (#29355)
1b27b56 
Related: supabase/cli#2688
@sweatybridge sweatybridge mentioned this pull request Oct 16, 2024
Merged
encima pushed a commit to supabase/supabase that referenced this pull request Nov 19, 2024
@avallete @encima
chore: document atomic function.enabled config flag (#29355)
eb81708 
Related: supabase/cli#2688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore function when deploy all
3 participants
@avallete @coveralls @sweatybridge