-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logout credentials cleanup #2670
Merged
sweatybridge
merged 15 commits into
supabase:develop
from
avallete:avallete/fix-logout-credentials-cleanup
Sep 13, 2024
Merged
fix: logout credentials cleanup #2670
sweatybridge
merged 15 commits into
supabase:develop
from
avallete:avallete/fix-logout-credentials-cleanup
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
force-pushed
the
avallete/fix-logout-credentials-cleanup
branch
from
September 10, 2024 16:37
3869f28
to
173f861
Compare
Pull Request Test Coverage Report for Build 10849056342Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We might refactor this code further once upstream supports DeleteAll.
Thank you for the thorough review and valuable feedback! I've made the suggested changes. |
sweatybridge
approved these changes
Sep 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
DeleteAll
method, removing all credentials associated with a serviceWhat is the current behavior?
Linked projects credentials stay within the keychain even after logout.
Fixes #2594
Additional context
I'm pretty sure there might be a cleaner method in go to just "extend" the "zalando/go-keyring" module, instead of importing it as a whole. I think I could do some refactoring if pointed in the right direction for that. In the meantime, this allowed me to test the new behavior on OSX.
TODO: Test on Linux and Windows