Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default to files:read scope for Figma provider #1831

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

smogg
Copy link
Contributor

@smogg smogg commented Nov 4, 2024

Closes #1827 by defaulting to files:read oAuth scope for Figma as per the issue.

@smogg smogg requested a review from a team as a code owner November 4, 2024 16:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11680631891

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 57.033%

Totals Coverage Status
Change from base Build 11632677259: -0.002%
Covered Lines: 9545
Relevant Lines: 16736

💛 - Coveralls

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@J0 J0 changed the title Default to files:read scope for Figma provider fix: default to files:read scope for Figma provider Nov 12, 2024
@J0
Copy link
Contributor

J0 commented Nov 12, 2024

At first glance, Figma docs don't need updating (couldn't find scope via ctrl-F)

@J0 J0 merged commit 9ce2857 into supabase:master Nov 12, 2024
2 checks passed
hbasria added a commit to hbasria/auth that referenced this pull request Nov 12, 2024
fix: default to files:read scope for Figma provider (supabase#1831)
J0 pushed a commit that referenced this pull request Nov 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.164.0](v2.163.2...v2.164.0)
(2024-11-13)


### Features

* return validation failed error if captcha request was not json
([#1815](#1815))
([26d2e36](26d2e36))


### Bug Fixes

* add error codes to refresh token flow
([#1824](#1824))
([4614dc5](4614dc5))
* add test coverage for rate limits with 0 permitted events
([#1834](#1834))
([7c3cf26](7c3cf26))
* correct web authn aaguid column naming
([#1826](#1826))
([0a589d0](0a589d0))
* default to files:read scope for Figma provider
([#1831](#1831))
([9ce2857](9ce2857))
* improve error messaging for http hooks
([#1821](#1821))
([fa020d0](fa020d0))
* make drop_uniqueness_constraint_on_phone idempotent
([#1817](#1817))
([158e473](158e473))
* possible panic if refresh token has a null session_id
([#1822](#1822))
([a7129df](a7129df))
* rate limits of 0 take precedence over MAILER_AUTO_CONFIRM
([#1837](#1837))
([cb7894e](cb7894e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth provider Figma uses deprecated scope
4 participants