fix: check for phone identity on Phone Change

[J0]

What kind of change does this PR introduce?

Allows user to change phone number to that of another unconfirmed phone number in they system

What is the current behavior?

Currently, it is not possible to use a phone number which exists in the system but is unconfirmed. Consider the following scenario:

User A signs up with phone number PN but doesn't confirm the number.
User B signs up with phone number PN2 and confirms it.
User B tries to update their phone number to PN -> this fails because User A has signed up with it already.

What is the new behavior?

It is possible to change phone number to one that is tagged to another user but unconfirmed.

User A signs up with phone number PN but doesn't confirm the number.
User B signs up with phone number PN2 and confirms it.
User B tries to update their phone number to PN -> this succeeds.

Check is done via phone identity,

Additional context

• Add a test

[coveralls]

Pull Request Test Coverage Report for Build 11799454604

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
• 130 unchanged lines in 8 files lost coverage.
• Overall coverage decreased (-0.08%) to 57.081%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/models/user.go	12	14	85.71%

Files with Coverage Reduction	New Missed Lines	%
internal/models/user.go	1	75.71%
internal/api/provider/figma.go	2	89.29%
internal/api/helpers.go	5	80.49%
internal/security/captcha.go	11	68.52%
internal/api/errors.go	18	63.51%
internal/api/admin.go	23	65.81%
internal/api/middleware.go	31	80.52%
internal/api/token_refresh.go	39	66.84%

Totals
Change from base Build 11548689337:	-0.08%
Covered Lines:	9561
Relevant Lines:	16750

---

💛 - Coveralls