Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow aliases on local development #1524

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

J0
Copy link
Contributor

@J0 J0 commented Apr 9, 2024

What kind of change does this PR introduce?

Allow developers to use aliases such as kong and edge_functions for local development as host.docker.internal might not be compatible on all platforms

Link: supabase/cli#2129 (comment)

By default, we allow the following HTTP HostNames: localhost, 127.0.0.1, ::1, host.docker.internal.

@J0 J0 requested a review from a team as a code owner April 9, 2024 23:48
@coveralls
Copy link

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8623798274

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.172%

Totals Coverage Status
Change from base Build 8614802879: 0.0%
Covered Lines: 8052
Relevant Lines: 12355

💛 - Coveralls

Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we make the hostname an internal config option which we can set? makes it easier to update as well

internal/conf/configuration.go Outdated Show resolved Hide resolved
@J0 J0 force-pushed the j0/allow_kong_and_edge_functions branch from b86179f to f2422a2 Compare October 21, 2024 17:18
@coveralls
Copy link

coveralls commented Oct 21, 2024

Pull Request Test Coverage Report for Build 11798245254

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 12 (91.67%) changed or added relevant lines in 1 file are covered.
  • 269 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.002%) to 57.044%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/conf/configuration.go 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
internal/api/provider/figma.go 2 89.29%
internal/api/helpers.go 5 80.49%
internal/api/mail.go 8 55.49%
internal/security/captcha.go 11 68.52%
internal/api/phone.go 16 81.82%
internal/api/errors.go 18 63.51%
internal/api/admin.go 23 65.81%
internal/api/token_refresh.go 39 66.84%
internal/api/middleware.go 45 80.52%
internal/conf/configuration.go 102 71.93%
Totals Coverage Status
Change from base Build 11351205156: -0.002%
Covered Lines: 9552
Relevant Lines: 16745

💛 - Coveralls

@J0 J0 force-pushed the j0/allow_kong_and_edge_functions branch from 3e3661b to 427823d Compare October 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants