chore(refactor): reduce parsing query params unnecessarily #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Dec 12, 2024
kangmingtay
force-pushed
the
km/ref-get-session-from-url
branch
from
890a0e7 to
05215e6
Compare
hf
added a commit
that referenced
this pull request
Dec 13, 2024
hf
pushed a commit
that referenced
this pull request
Dec 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.67.1](v2.67.0...v2.67.1) (2024-12-13) ### Bug Fixes * revert [#992](#992) and [#993](#993) ([#999](#999)) ([12b2848](12b2848)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kangmingtay
added a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
_getSessionFromURL,_isPKCEFlowand_isImplicitGrantFlow- previously we were parsing the url parameters multiple times which was unnecessary. Now, we parse it once and pass it in as an argument in other functions that need it.getSessionFromURLshould only be called in a browser context and ifdetectSessionInURLis set.