fix: isBrowser() to include typeof window !== 'undefined' check #982
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several checks in GoTrueClient.ts that check window?.[prop] after checking isBrowser() which throws an error in node environments that have "document" defined but not "window". So this is the most minimal check to be sure they don't throw by ensuring "window" is defined.
salmoro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes supabase/supabase-js#786
What is the current behavior?
There are several checks in
GoTrueClient.tsthat checkwindow?.[prop]after checkingisBrowser()which throws an error in node environments that havedocumentdefined but notwindow.What is the new behavior?
Adds the most minimal check to be sure they don't throw by ensuring
windowis defined.