-
-
Notifications
You must be signed in to change notification settings - Fork 166
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add process lock for optional use in non-browser environments (…
…React Native) (#977) When using the library in non-browser environments like React Native or other JavaScript-based runtimes (Electron's main process for example) certain race conditions could still occur. We've received some signal from customers using React Native that at scale these become more visible. This is why I'm introducing a `processLock` that developers can import like so: ```typescript import { processLock } from '@supabase/auth-js/lib/locks' ``` And add to their apps by specifying the lock option with the process lock.
- Loading branch information
Showing
2 changed files
with
136 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import { processLock } from '../../src/lib/locks' | ||
|
||
describe('processLock', () => { | ||
it('should serialize access correctly', async () => { | ||
const timestamps: number[] = [] | ||
const operations: Promise<any>[] = [] | ||
|
||
let expectedDuration = 0 | ||
|
||
for (let i = 0; i <= 1000; i += 1) { | ||
const acquireTimeout = Math.random() < 0.3 ? Math.ceil(10 + Math.random() * 100) : -1 | ||
|
||
operations.push( | ||
(async () => { | ||
try { | ||
await processLock('name', acquireTimeout, async () => { | ||
const start = Date.now() | ||
|
||
timestamps.push(start) | ||
|
||
let diff = Date.now() - start | ||
|
||
while (diff < 10) { | ||
// setTimeout is not very precise, sometimes it actually times out a bit earlier | ||
// so this cycle ensures that it has actually taken >= 10ms | ||
await new Promise((accept) => { | ||
setTimeout(() => accept(null), Math.max(1, 10 - diff)) | ||
}) | ||
|
||
diff = Date.now() - start | ||
} | ||
|
||
expectedDuration += Date.now() - start | ||
}) | ||
} catch (e: any) { | ||
if (acquireTimeout > -1 && e && e.isAcquireTimeout) { | ||
return null | ||
} | ||
|
||
throw e | ||
} | ||
})() | ||
) | ||
} | ||
|
||
const start = Date.now() | ||
|
||
await Promise.all(operations) | ||
|
||
const end = Date.now() | ||
|
||
expect(end - start).toBeGreaterThanOrEqual(expectedDuration) | ||
expect(Math.ceil((end - start) / timestamps.length)).toBeGreaterThanOrEqual(10) | ||
|
||
for (let i = 1; i < timestamps.length; i += 1) { | ||
expect(timestamps[i]).toBeGreaterThan(timestamps[i - 1]) | ||
} | ||
|
||
for (let i = 1; i < timestamps.length; i += 1) { | ||
expect(timestamps[i] - timestamps[i - 1]).toBeGreaterThanOrEqual(10) | ||
} | ||
}, 15_000) | ||
}) |