New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel: Use SeqCst for ARE_CPU_LOCALS_INIT #489

Open

roblabla wants to merge 1 commit into sunriseos:master from roblabla:bugfix-arecpulocalsinit-atomic

Member

roblabla commented Sep 22, 2019

Relaxed is 100% broken in SMP context here.


          Kernel: Use SeqCst for ARE_CPU_LOCALS_INIT

407b117

marysaka approved these changes

View reviewed changes

Member Author

roblabla commented Sep 22, 2019

From @Orycterope on discord

Since we set the atomic to true before we start the other cores, shouldn't Relaxed work?

I'm not 100% sure. I feel like it should work in practice, but I'm very unclear on whether this is considered legal or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet