fix regex character class order in simple_html_dom.php #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanu
reviewed
Nov 29, 2021
| @@ -693,7 +693,7 @@ protected function parse_selector($selector_string) { | |||
| // This implies that an html attribute specifier may start with an @ sign that is NOT captured by the expression. | |||
| // farther study is required to determine of this should be documented or removed. | |||
| // $pattern = "/([\w-:\*]*)(?:\#([\w-]+)|\.([\w-]+))?(?:\[@?(!?[\w-]+)(?:([!*^$]?=)[\"']?(.*?)[\"']?)?\])?([\/, ]+)/is"; | |||
| $pattern = "/([\w-:\*]*)(?:\#([\w-]+)|\.([\w-]+))?(?:\[@?(!?[\w-:]+)(?:([!*^$]?=)[\"']?(.*?)[\"']?)?\])?([\/, ]+)/is"; | |||
| $pattern = "/([-:\*\w]*)(?:\#([-\w]+)|\.([-\w]+))?(?:\[@?(!?[-\w:]+)(?:([!*^$]?=)[\"']?(.*?)[\"']?)?\])?([\/, ]+ | |||
There was a problem hiding this comment.
You gonna get an error without ; at the end of line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the dashes in character classes is affected by later versions of PHP, changing the order of the character ranges fixes the problem, have shortcodes after any dashes.
I noticed when upgrading to 7.4.3
the problem is explained here
https://stackoverflow.com/a/24767090/2831388
causes a couple of errors:
Compilation failed: invalid range in character class at offset 4in simple_html_dom.php on line 1378and a similar error on line 696