Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation mode added as a new metadata. #140

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NucleonGodX
Copy link
Contributor

As from Eric's suggestion I've added support for observation mode for remote sensing instrument tables.

@NucleonGodX NucleonGodX marked this pull request as draft July 24, 2024 15:52
@nabobalis nabobalis marked this pull request as ready for review August 3, 2024 17:02
@@ -25,6 +25,12 @@ class SOOP(SimpleAttr):
"""


class ObservationMode(SimpleAttr):
"""
The mode of observation to search for.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have a fixed set of values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, for all instruments except SPICE, there aren't many observation modes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what they are or if we can with that out?

Copy link
Contributor Author

@NucleonGodX NucleonGodX Aug 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make a list, As Eric suggested for SPICE there are around 80-90. And for others there aren't a lot.

@nabobalis
Copy link
Contributor

I think a how to section on using this might be nice?

@NucleonGodX
Copy link
Contributor Author

I think a how to section on using this might be nice?

Are we interested in adding a data file for it, like we have for SOOP and Product?

@nabobalis
Copy link
Contributor

I think a how to section on using this might be nice?

Are we interested in adding a data file for it, like we have for SOOP and Product?

If we can programmatically create it then yes

@NucleonGodX
Copy link
Contributor Author

So I tried to fetch all values of observation modes for EUI, PHI, METIS, SOLOHI and SPICE, and the number is 329(i don't really know if it covers all but it should) out of this 244 are of SPICE.

@nabobalis
Copy link
Contributor

So I tried to fetch all values of observation modes for EUI, PHI, METIS, SOLOHI and SPICE, and the number is 329(i don't really know if it covers all but it should) out of this 244 are of SPICE.

How did you fetch them? We should add a script that fetches them and saves them to a json file.
We should make sure we do this with any fixed values we store.

@NucleonGodX
Copy link
Contributor Author

So I tried to fetch all values of observation modes for EUI, PHI, METIS, SOLOHI and SPICE, and the number is 329(i don't really know if it covers all but it should) out of this 244 are of SPICE.

How did you fetch them? We should add a script that fetches them and saves them to a json file. We should make sure we do this with any fixed values we store.

I don't really know how reliable my method was, I queried data over time that covers all data of instruments and then downloaded JSON files of it for every instrument and ran a python script over that data, to extract unique values of Observation mode in it.

@nabobalis
Copy link
Contributor

So I tried to fetch all values of observation modes for EUI, PHI, METIS, SOLOHI and SPICE, and the number is 329(i don't really know if it covers all but it should) out of this 244 are of SPICE.

How did you fetch them? We should add a script that fetches them and saves them to a json file. We should make sure we do this with any fixed values we store.

I don't really know how reliable my method was, I queried data over time that covers all data of instruments and then downloaded JSON files of it for every instrument and ran a python script over that data, to extract unique values of Observation mode in it.

Thats a decent place to start but we should ask the SOAR if there is an endpoint we can use to get this information.

@NucleonGodX
Copy link
Contributor Author

So I tried to fetch all values of observation modes for EUI, PHI, METIS, SOLOHI and SPICE, and the number is 329(i don't really know if it covers all but it should) out of this 244 are of SPICE.

How did you fetch them? We should add a script that fetches them and saves them to a json file. We should make sure we do this with any fixed values we store.

I don't really know how reliable my method was, I queried data over time that covers all data of instruments and then downloaded JSON files of it for every instrument and ran a python script over that data, to extract unique values of Observation mode in it.

Thats a decent place to start but we should ask the SOAR if there is an endpoint we can use to get this information.

Yeah, that will be ideal.

@herroyalmaj
Copy link

Hi,
I might have missed something here, but the lists can be got using
SELECT DISTINCT observation_mode FROM v_<instrument>_sc_fits
Is that what was wanted?
They seem to be very individual to each instrument so I'm not sure how you plan on using them?

@NucleonGodX
Copy link
Contributor Author

Hi, I might have missed something here, but the lists can be got using SELECT DISTINCT observation_mode FROM v_<instrument>_sc_fits Is that what was wanted? They seem to be very individual to each instrument so I'm not sure how you plan on using them?

Yes, this does the job, Thanks

@nabobalis
Copy link
Contributor

Hi, I might have missed something here, but the lists can be got using SELECT DISTINCT observation_mode FROM v_<instrument>_sc_fits Is that what was wanted? They seem to be very individual to each instrument so I'm not sure how you plan on using them?

My inspiration is from IRIS where there are OBSID and people can filter by those observation modes if they are after a specific set of observation characteristic.
I have assumed these are similar for SoLo and hope that users might find usefulness in filtering via that keyword.

@NucleonGodX
Copy link
Contributor Author

@nabobalis how would you want the how-to guide for this look like? Like how should we navigate the user?

@nabobalis
Copy link
Contributor

@nabobalis how would you want the how-to guide for this look like? Like how should we navigate the user?

Hmm, I am worried that simple how to guides defeat the purpose of a how to but maybe that's ok?

I would start off by saying showing a subset of what observation modes are available, by printing the net attr.

Do we know if there is any documentation about it on the SOAR or instrument websites?

Then I would filter by an observation mode and I would warn that if you do multi instrument search with the observation mode filter, there will be only results for the valid instrument? showcasing how to chain them together would be nice.

@hayesla
Copy link
Member

hayesla commented Aug 6, 2024

Hmm, I thought maybe we wouldnt go ahead with this. Looking at the different observing modes, will users actually know what to do here? I'm not sure it adds useful functionality. And its quite different to the OBSID that IRIS uses?

I'm in favor of not adding this at the moment, as its quite instrument specific and not clear what these different modes even are. Like theres also no explicit info in how we provide these to what instrument they are associated with.

@hayesla
Copy link
Member

hayesla commented Aug 6, 2024

or if we do add it, it just is added to the returned table, rather than having it as an attribute we can search on. The ObservingMode attribute could mean many things, and I personally think it going to confuse users. I need to think a little bit about this, but I'm still in favor of not having it at the moment.

@nabobalis nabobalis marked this pull request as draft August 14, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants