-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observation mode added as a new metadata. #140
base: main
Are you sure you want to change the base?
Conversation
@@ -25,6 +25,12 @@ class SOOP(SimpleAttr): | |||
""" | |||
|
|||
|
|||
class ObservationMode(SimpleAttr): | |||
""" | |||
The mode of observation to search for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have a fixed set of values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, for all instruments except SPICE, there aren't many observation modes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what they are or if we can with that out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make a list, As Eric suggested for SPICE there are around 80-90. And for others there aren't a lot.
I think a how to section on using this might be nice? |
Are we interested in adding a data file for it, like we have for SOOP and Product? |
If we can programmatically create it then yes |
So I tried to fetch all values of observation modes for EUI, PHI, METIS, SOLOHI and SPICE, and the number is 329(i don't really know if it covers all but it should) out of this 244 are of SPICE. |
How did you fetch them? We should add a script that fetches them and saves them to a json file. |
I don't really know how reliable my method was, I queried data over time that covers all data of instruments and then downloaded JSON files of it for every instrument and ran a python script over that data, to extract unique values of Observation mode in it. |
Thats a decent place to start but we should ask the SOAR if there is an endpoint we can use to get this information. |
Yeah, that will be ideal. |
Hi, |
Yes, this does the job, Thanks |
My inspiration is from IRIS where there are OBSID and people can filter by those observation modes if they are after a specific set of observation characteristic. |
@nabobalis how would you want the how-to guide for this look like? Like how should we navigate the user? |
Hmm, I am worried that simple how to guides defeat the purpose of a how to but maybe that's ok? I would start off by saying showing a subset of what observation modes are available, by printing the net attr. Do we know if there is any documentation about it on the SOAR or instrument websites? Then I would filter by an observation mode and I would warn that if you do multi instrument search with the observation mode filter, there will be only results for the valid instrument? showcasing how to chain them together would be nice. |
Hmm, I thought maybe we wouldnt go ahead with this. Looking at the different observing modes, will users actually know what to do here? I'm not sure it adds useful functionality. And its quite different to the OBSID that IRIS uses? I'm in favor of not adding this at the moment, as its quite instrument specific and not clear what these different modes even are. Like theres also no explicit info in how we provide these to what instrument they are associated with. |
or if we do add it, it just is added to the returned table, rather than having it as an attribute we can search on. The |
As from Eric's suggestion I've added support for observation mode for remote sensing instrument tables.