Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hack #458

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Remove hack #458

merged 7 commits into from
Mar 5, 2024
+20 −33

Conversation

Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Mar 4, 2024 •
edited
Loading

  • I have run pytest .tests/ on a local deployment and the tests passed successfully
  • If this adds a new output file, I have added a check to .tests/targets.txt
  • If this fixes a bug, I have added or modified an appropriate test
  • If this adds or modifies a rule that uses FASTQ files, the input accepts gzipped FASTQ and outputs gzipped FASTQ, or marks uncompressed FASTQ output as temp

If this is for a release:

  • I have updated documentation
  • I have updated all conda pin files (snakedeploy pin-conda-envs workflow/envs/*.yml)
  • I have updated the hardcoded version at the top of install.sh to match what this release's version will be
  • I have created a release archive that will be attached to this release (bash dev_scripts/generate_archive.sh)

@Ulthran Ulthran linked an issue Mar 4, 2024 that may be closed by this pull request
Remove slurm_executor hack #457
Closed
@Ulthran Ulthran merged commit 0f6e499 into main Mar 5, 2024
6 checks passed
@Ulthran Ulthran deleted the 457-remove-slurm_executor-hack branch March 5, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove slurm_executor hack
1 participant
@Ulthran