Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade interactions with slurm #451

Closed

Conversation

Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Feb 1, 2024

  • I have run pytest .tests/ on a local deployment and the tests passed successfully
  • If this adds a new output file, I have added a check to .tests/targets.txt
  • If this fixes a bug, I have added or modified an appropriate test
  • If this adds or modifies a rule that uses FASTQ files, the input accepts gzipped FASTQ and outputs gzipped FASTQ, or marks uncompressed FASTQ output as temp

If this is for a release:

  • I have updated documentation
  • I have updated all conda pin files (snakedeploy pin-conda-envs workflow/envs/*.yml)
  • I have updated the hardcoded version at the top of install.sh to match what this release's version will be
  • I have created a release archive that will be attached to this release (bash dev_scripts/generate_archive.sh)

@Ulthran Ulthran linked an issue Feb 1, 2024 that may be closed by this pull request
@Ulthran
Copy link
Contributor Author

Ulthran commented Feb 2, 2024

snakemake/snakemake#2627

Potential fix for this included in snakemake 8.4.3, once it's on bioconda we can try it out

@Ulthran
Copy link
Contributor Author

Ulthran commented Feb 12, 2024

This is overridden by #454

@Ulthran Ulthran closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use --cluster-status to properly end cluster workflows
1 participant