Handle purls missing a public json record. #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlittman
approved these changes
Oct 11, 2024
lwrubel
force-pushed
the
t5181-no-public-json
branch
2 times, most recently
from
94f212a
to
a614e8a
Compare
lwrubel
force-pushed
the
t5181-no-public-json
branch
from
a614e8a
to
12c9457
Compare
jcoyne
reviewed
Oct 11, 2024
| - name: Run tests (with content addressed storage feature flag enabled) | ||
| run: SETTINGS__FEATURES__AWFL_METADATA=true SETTINGS__FEATURES__AWFL=true bundle exec rake | ||
| - name: Run tests | ||
| run: bundle exec rake |
There was a problem hiding this comment.
Isn't this now the same as line 21?
lwrubel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily prevent these items from erroring on republish because they currently are missing public JSON records.
Tested by modifying a purl on purl-fetcher stage to have no public json and a cocina.json without currently valid cocina. Republished successfully, with no errors, creating a PublicJson record and updating the cocina.json