Merge pull request #4364 from sul-dlss/remove-obsolete-fix

Remove an obsolete fix for skip to nav links

app/javascript/application.js

@@ -51,12 +51,11 @@ import "./preview-content";
 import "./recent-selections";
 import "./select-all";
 import "./sfx-panel";
-import "./skip-to-nav";
 import "./tooltip";
 import "./truncate";
 import "./update-hidden-inputs-by-checkbox";
 
-// TODO: Remove this whole method when we upgrade to Blacklight 8, provided that 
+// TODO: Remove this whole method when we upgrade to Blacklight 8, provided that
 //       https://github.com/projectblacklight/blacklight/pull/3133 is merged
 //
 // Add the passed in contents to the modal and display it.
@@ -97,4 +96,4 @@ document.addEventListener("turbo:before-cache", function () {
 });
 
 import "./controllers"
-import "./controllers/external"
+import "./controllers/external"

spec/features/skip_to_nav_spec.rb

@@ -41,20 +41,6 @@
     end
   end
 
-  scenario 'places focus on traditionally non-focusable elements', :js do
-    visit root_path
-
-    body_element = page.find("body")
-    body_element.native.send_keys(:tab)
-    body_element.native.send_keys(:tab)
-
-    within '#skip-link' do
-      click_link 'Skip to main content'
-      active_element = page.evaluate_script('$(document.activeElement).attr("id")')
-      expect(active_element).to eq 'main-container'
-    end
-  end
-
   scenario "has skip-to navigation links to search field, main container and records in record view page" do
     visit solr_document_path 20