Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemsJS Library #148

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

ItemsJS Library #148

wants to merge 4 commits into from

Conversation

markpernotto
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for pianolatron-develop ready!

Name Link
🔨 Latest commit a925434
🔍 Latest deploy log https://app.netlify.com/sites/pianolatron-develop/deploys/6535f0b90e4be40008f34d3b
😎 Deploy Preview https://deploy-preview-148--pianolatron-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@broadwell
Copy link
Contributor

Cool, this looks good, too! Hmm...
The facets/filters on the left side with the tallies of the matching elements is a nice feature -- not strictly necessary, but nice. Any idea whether the search piece can be configured to do expansion from ASCII characters to their diacritical forms out of the box? That's close to an essential feature given the large numbers of umlauts and accents in the roll data.
Besides coverage of the essential features, our final choice of a framework for the search and browse page also may come down to factors like perceived maintainability, ease of integration into the rest of the codebase, and how much it adds to the JS download bundle.

@broadwell broadwell marked this pull request as draft November 9, 2023 12:24
@broadwell
Copy link
Contributor

Moving this to draft status until we get the chance to come back to it and determine whether there are ways to get the features we want out of it while also retaining the best features that the GridJS implementation provides.

@broadwell broadwell added the WIP work in progress label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants