Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: a few 'metadata' and the 'annotation' components to Typescript #4

Merged
merged 4 commits into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"standard-version": "^9.5.0",
"start-server-and-test": "^2.0.3",
"tailwindcss": "^3.4.1",
"typescript": "^5.4.5",
paulpestov marked this conversation as resolved.
Show resolved Hide resolved
"vite": "^5.2.6",
"vue": "^3.4.20",
"vue-i18n": "^9.2.0-beta.35",
Expand Down
10 changes: 6 additions & 4 deletions src/components/annotations/AnnotationIcon.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
/>
</template>

<script setup>
<script setup lang="ts">
import BaseIcon from '@/components/base/BaseIcon.vue';

const props = defineProps({
name: String,
});
interface Props {
name: string
}
const props = defineProps<Props>()

</script>

<style scoped>
Expand Down
40 changes: 20 additions & 20 deletions src/components/annotations/AnnotationsList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,40 +21,40 @@
</div>
</template>

<script setup>
<script setup lang="ts">
import { computed, watch } from 'vue';
import AnnotationIcon from '@/components/annotations/AnnotationIcon.vue';

const props = defineProps({
activeAnnotation: {
type: Object,
default: () => {},
},
configuredAnnotations: {
type: Array,
default: () => [],
},
toggle: {
type: Function,
default: () => null,
},
types: Array,
});

const annotationTypesMapping = computed(() => (
export interface Props {
activeAnnotation: ActiveAnnotation
configuredAnnotations: Annotation[],
toggle: Function,
types: any[]
}

const props = withDefaults(defineProps<Props>(), {
activeAnnotation: () => <ActiveAnnotation>{},
configuredAnnotations: () => <Annotation[]> [],
toggle: () => null,
})

const annotationTypesMapping = computed<Object>(() => (
paulpestov marked this conversation as resolved.
Show resolved Hide resolved
// it returns an object with a varying number of 'key', 'value' pairs
props.types.reduce((prev, curr) => {
prev[curr.name] = curr.annotationType || 'annotation';
return prev;
}, {})
));

function isActive(annotation) {
function isActive(annotation: Annotation): boolean {
return !!props.activeAnnotation[annotation.id];
}
function isText(annotation) {
function isText(annotation: Annotation) : boolean {
paulpestov marked this conversation as resolved.
Show resolved Hide resolved
return annotationTypesMapping.value[annotation.body['x-content-type']] === 'text';
}
function getIconName(typeName) {
function getIconName(typeName: string): string {
// Question: is there any range of values for the typeName ? I set it to 'string' by considering examples when just printing it
paulpestov marked this conversation as resolved.
Show resolved Hide resolved
return props.types.find(({ name }) => name === typeName)?.icon || 'biPencilSquare';
}
</script>
14 changes: 7 additions & 7 deletions src/components/annotations/AnnotationsView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</div>
</template>

<script setup>
<script setup lang="ts">
import {
computed, onBeforeUnmount, ref, watch,
} from 'vue';
Expand All @@ -37,10 +37,10 @@ const store = useStore();
const message = ref('no_annotations_in_view');

const config = computed(() => store.getters['config/config']);
const annotations = computed(() => store.getters['annotations/annotations']);
const activeAnnotations = computed(() => store.getters['annotations/activeAnnotations']);
const filteredAnnotations = computed(() => store.getters['annotations/filteredAnnotations']);
const activeContentUrl = computed(() => store.getters['contents/activeContentUrl']);
const annotations = computed<Annotation[]>(() => store.getters['annotations/annotations']);
const activeAnnotations = computed<ActiveAnnotation>(() => store.getters['annotations/activeAnnotations']);
const filteredAnnotations = computed<Annotation[]>(() => store.getters['annotations/filteredAnnotations']);
const activeContentUrl = computed<string>(() => store.getters['contents/activeContentUrl']);
const updateTextHighlighting = computed(() =>
// We need to make sure that annotations are loaded (this.annotations),
// the text HTML is present in DOM (this.activeContentUrl is set after DOM update)
Expand All @@ -59,11 +59,11 @@ watch(
{ immediate: true },
);

function addAnnotation(id) {
function addAnnotation(id: string) {
store.dispatch('annotations/addActiveAnnotation', id);
}

function removeAnnotation(id) {
function removeAnnotation(id: string) {
store.dispatch('annotations/removeActiveAnnotation', id);
}

Expand Down
21 changes: 10 additions & 11 deletions src/components/metadata/MetadataLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,17 @@
</a>
</template>

<script setup>
<script setup lang="ts">
import BaseIcon from '@/components/base/BaseIcon.vue';

const props = defineProps({
url: {
type: String,
default: () => '',
},
text: {
type: String,
default: () => '',
},
});
export interface Props {
url: string,
text: string
}

const props = withDefaults(defineProps<Props>(), {
url: '',
text: ''
})

</script>
16 changes: 9 additions & 7 deletions src/components/metadata/MetadataValue.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
</div>
</template>

<script setup>
const props = defineProps({
value: {
type: String,
default: () => '',
},
});
<script setup lang="ts">

export interface Props {
value?: string
}

const props = withDefaults(defineProps<Props>(), {
value: ''
})
</script>

<style lang="scss" scoped>
Expand Down
41 changes: 40 additions & 1 deletion src/types.d.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,42 @@
declare global {

interface Annotation {
body: AnnotationContent[],
target: AnnotationTarget[],
type: string,
id: string
}

interface ActiveAnnotation {
[key: string]: Annotation
}

interface Actor {
'@context': string,
role: string[]
role: string[],
name: string,
id?: string,
idref?: Idref[]

}

interface AnnotationContent {
type: 'TextualBody',
value: string,
format: AnnotationContentFormat,
'x-content-type': AnnotationContentType
}

type AnnotationContentFormat = 'text/plain' | 'text/html'
type AnnotationContentType = 'Person' | 'Place'

interface AnnotationTarget {
selector: CssSelector | RangeSelector,
format: string,
language: string,
source: string
}

interface Collection {
'@context': string,
textapi: string,
Expand All @@ -30,6 +58,12 @@ declare global {
integrity?: DataIntegrity
}


type CssSelector = {
type: 'CssSelector',
value: string
}

interface DataIntegrity {
type: string,
value: string
Expand Down Expand Up @@ -107,6 +141,11 @@ declare global {
editionPrints?: boolean
}

type RangeSelector = {
type: 'RangeSelector',
startSelector: CssSelector,
endSelector: CssSelector
}
interface Repository {
'@context': string,
label?: string,
Expand Down
112 changes: 112 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
{
paulpestov marked this conversation as resolved.
Show resolved Hide resolved
"compilerOptions": {
/* Visit https://aka.ms/tsconfig to read more about this file */

/* Projects */
// "incremental": true, /* Save .tsbuildinfo files to allow for incremental compilation of projects. */
// "composite": true, /* Enable constraints that allow a TypeScript project to be used with project references. */
// "tsBuildInfoFile": "./.tsbuildinfo", /* Specify the path to .tsbuildinfo incremental compilation file. */
// "disableSourceOfProjectReferenceRedirect": true, /* Disable preferring source files instead of declaration files when referencing composite projects. */
// "disableSolutionSearching": true, /* Opt a project out of multi-project reference checking when editing. */
// "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */

/* Language and Environment */
"target": "es2016", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
// "lib": [], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
// "jsx": "preserve", /* Specify what JSX code is generated. */
// "experimentalDecorators": true, /* Enable experimental support for legacy experimental decorators. */
// "emitDecoratorMetadata": true, /* Emit design-type metadata for decorated declarations in source files. */
// "jsxFactory": "", /* Specify the JSX factory function used when targeting React JSX emit, e.g. 'React.createElement' or 'h'. */
// "jsxFragmentFactory": "", /* Specify the JSX Fragment reference used for fragments when targeting React JSX emit e.g. 'React.Fragment' or 'Fragment'. */
// "jsxImportSource": "", /* Specify module specifier used to import the JSX factory functions when using 'jsx: react-jsx*'. */
// "reactNamespace": "", /* Specify the object invoked for 'createElement'. This only applies when targeting 'react' JSX emit. */
// "noLib": true, /* Disable including any library files, including the default lib.d.ts. */
// "useDefineForClassFields": true, /* Emit ECMAScript-standard-compliant class fields. */
// "moduleDetection": "auto", /* Control what method is used to detect module-format JS files. */

/* Modules */
"module": "commonjs", /* Specify what module code is generated. */
"rootDir": "./src", /* Specify the root folder within your source files. */
// "moduleResolution": "node10", /* Specify how TypeScript looks up a file from a given module specifier. */
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
// "rootDirs": [], /* Allow multiple folders to be treated as one when resolving modules. */
// "typeRoots": [], /* Specify multiple folders that act like './node_modules/@types'. */
// "types": [], /* Specify type package names to be included without being referenced in a source file. */
// "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */
// "moduleSuffixes": [], /* List of file name suffixes to search when resolving a module. */
// "allowImportingTsExtensions": true, /* Allow imports to include TypeScript file extensions. Requires '--moduleResolution bundler' and either '--noEmit' or '--emitDeclarationOnly' to be set. */
// "resolvePackageJsonExports": true, /* Use the package.json 'exports' field when resolving package imports. */
// "resolvePackageJsonImports": true, /* Use the package.json 'imports' field when resolving imports. */
// "customConditions": [], /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
// "resolveJsonModule": true, /* Enable importing .json files. */
// "allowArbitraryExtensions": true, /* Enable importing files with any extension, provided a declaration file is present. */
// "noResolve": true, /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

/* JavaScript Support */
"allowJs": true, /* Allow JavaScript files to be a part of your program. Use the 'checkJS' option to get errors from these files. */
// "checkJs": true, /* Enable error reporting in type-checked JavaScript files. */
// "maxNodeModuleJsDepth": 1, /* Specify the maximum folder depth used for checking JavaScript files from 'node_modules'. Only applicable with 'allowJs'. */

/* Emit */
// "declaration": true, /* Generate .d.ts files from TypeScript and JavaScript files in your project. */
// "declarationMap": true, /* Create sourcemaps for d.ts files. */
// "emitDeclarationOnly": true, /* Only output d.ts files and not JavaScript files. */
"sourceMap": true, /* Create source map files for emitted JavaScript files. */
// "inlineSourceMap": true, /* Include sourcemap files inside the emitted JavaScript. */
// "outFile": "./", /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
"outDir": "./dist", /* Specify an output folder for all emitted files. */
// "removeComments": true, /* Disable emitting comments. */
// "noEmit": true, /* Disable emitting files from a compilation. */
// "importHelpers": true, /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
// "importsNotUsedAsValues": "remove", /* Specify emit/checking behavior for imports that are only used for types. */
// "downlevelIteration": true, /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
// "sourceRoot": "", /* Specify the root path for debuggers to find the reference source code. */
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
// "inlineSources": true, /* Include source code in the sourcemaps inside the emitted JavaScript. */
// "emitBOM": true, /* Emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files. */
// "newLine": "crlf", /* Set the newline character for emitting files. */
// "stripInternal": true, /* Disable emitting declarations that have '@internal' in their JSDoc comments. */
// "noEmitHelpers": true, /* Disable generating custom helper functions like '__extends' in compiled output. */
"noEmitOnError": true, /* Disable emitting files if any type checking errors are reported. */
// "preserveConstEnums": true, /* Disable erasing 'const enum' declarations in generated code. */
// "declarationDir": "./", /* Specify the output directory for generated declaration files. */
// "preserveValueImports": true, /* Preserve unused imported values in the JavaScript output that would otherwise be removed. */

/* Interop Constraints */
// "isolatedModules": true, /* Ensure that each file can be safely transpiled without relying on other imports. */
// "verbatimModuleSyntax": true, /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
// "allowSyntheticDefaultImports": true, /* Allow 'import x from y' when a module doesn't have a default export. */
"esModuleInterop": true, /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
// "preserveSymlinks": true, /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */
"forceConsistentCasingInFileNames": true, /* Ensure that casing is correct in imports. */

/* Type Checking */
"strict": true, /* Enable all strict type-checking options. */
// "noImplicitAny": true, /* Enable error reporting for expressions and declarations with an implied 'any' type. */
// "strictNullChecks": true, /* When type checking, take into account 'null' and 'undefined'. */
// "strictFunctionTypes": true, /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */
// "strictBindCallApply": true, /* Check that the arguments for 'bind', 'call', and 'apply' methods match the original function. */
// "strictPropertyInitialization": true, /* Check for class properties that are declared but not set in the constructor. */
// "noImplicitThis": true, /* Enable error reporting when 'this' is given the type 'any'. */
// "useUnknownInCatchVariables": true, /* Default catch clause variables as 'unknown' instead of 'any'. */
// "alwaysStrict": true, /* Ensure 'use strict' is always emitted. */
// "noUnusedLocals": true, /* Enable error reporting when local variables aren't read. */
// "noUnusedParameters": true, /* Raise an error when a function parameter isn't read. */
// "exactOptionalPropertyTypes": true, /* Interpret optional property types as written, rather than adding 'undefined'. */
// "noImplicitReturns": true, /* Enable error reporting for codepaths that do not explicitly return in a function. */
// "noFallthroughCasesInSwitch": true, /* Enable error reporting for fallthrough cases in switch statements. */
// "noUncheckedIndexedAccess": true, /* Add 'undefined' to a type when accessed using an index. */
// "noImplicitOverride": true, /* Ensure overriding members in derived classes are marked with an override modifier. */
// "noPropertyAccessFromIndexSignature": true, /* Enforces using indexed accessors for keys declared using an indexed type. */
// "allowUnusedLabels": true, /* Disable error reporting for unused labels. */
// "allowUnreachableCode": true, /* Disable error reporting for unreachable code. */

/* Completeness */
// "skipDefaultLibCheck": true, /* Skip type checking .d.ts files that are included with TypeScript. */
"skipLibCheck": true /* Skip type checking all .d.ts files. */
},
"include": [
"src/**/*"
],
}