fix subcalls relation #321
Conversation
| @@ -405,6 +405,10 @@ export function setUpItems(block: Block): void { | |||
| rec.parentCall = prev | |||
| populateSubcalls(prev, rec) | |||
| } | |||
| if (prev.parentCall && isSubcall(prev.parentCall, rec)) { | |||
There was a problem hiding this comment.
nested calls are handled incorrectly.
[1, 1, 1], [1, 1], [1] -> the first will be subcall of the second, the second will be subcall of the third
[1, 1, 1], [1] -> the first will be subcall of the second
There was a problem hiding this comment.
yeah, i also expect that it works like that
There was a problem hiding this comment.
but i don't see the problem...
There was a problem hiding this comment.
ok if we talk about [1, 1, 1], [1] then there will be wrong parent assignment...
the parent will have the child as a subcall but i believe [1] shouldn't be in .parentCall
There was a problem hiding this comment.
idk that should be the correct behavior here, but isSubcall assumes that [1, 1, 1] is a subcall of [1]
There was a problem hiding this comment.
it is expected according to subcalls query - https://github.com/subsquid/archive.py/blob/master/sqa/substrate/query.py#L422-L426
There was a problem hiding this comment.
it is expected according to subcalls query
Not sure, I guess it only says "request all subcalls and thier children", but nothing about how they should be grouped
There was a problem hiding this comment.
yeah, another way is to put only direct "children" into subcalls array. i guess both options are fine...
@eldargab how subcalls are supposed to work?
There was a problem hiding this comment.
i got confirmation that subcalls represent all children
No description provided.