Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate fuel blocks consistency #300

Merged
merged 1 commit into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@subsquid/fuel-data",
"comment": "validate blocks consistency and retry query if invalid",
"type": "minor"
}
],
"packageName": "@subsquid/fuel-data"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@subsquid/fuel-normalization",
"comment": "make block.transactions optional",
"type": "minor"
}
],
"packageName": "@subsquid/fuel-normalization"
}
40 changes: 37 additions & 3 deletions fuel/fuel-data/src/data-source.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import {HttpClient} from '@subsquid/http-client'
import {Batch, coldIngest} from '@subsquid/util-internal-ingest-tools'
import {RangeRequest, SplitRequest} from '@subsquid/util-internal-range'
import {DataValidationError, GetSrcType, Validator} from '@subsquid/util-internal-validation'
import {wait} from '@subsquid/util-internal'
import assert from 'assert'
import {BlockData, Blocks, LatestBlockHeight, GetBlockHash, DataRequest, GetBlockHeader, BlockHeader} from './raw-data'
import {getLatesBlockQuery, getBlockHashQuery, getBlockHeaderQuery, getBlocksQuery} from './query'
import {getLatestBlockQuery, getBlockHashQuery, getBlockHeaderQuery, getBlocksQuery} from './query'


function getResultValidator<V extends Validator>(validator: V): (result: unknown) => GetSrcType<V> {
Expand Down Expand Up @@ -42,7 +43,7 @@ export class HttpDataSource {
}

async getFinalizedHeight(): Promise<number> {
let query = getLatesBlockQuery()
let query = getLatestBlockQuery()
let response: LatestBlockHeight = await this.request(query, getResultValidator(LatestBlockHeight))
let height = parseInt(response.chain.latestBlock.header.height)
assert(Number.isSafeInteger(height))
Expand Down Expand Up @@ -80,7 +81,16 @@ export class HttpDataSource {
let first = req.range.to - req.range.from + 1
let after = req.range.from == 0 ? undefined : req.range.from - 1
let query = getBlocksQuery(req.request, first, after)
let response: Blocks = await this.request(query, getResultValidator(Blocks))

let response = await this.retry(async () => {
let response: Blocks = await this.request(query, getResultValidator(Blocks))
let length = response.blocks.nodes.length
if (length != first) {
throw new BlocksConsistencyError(`Expected blocks length: ${first}, got ${length}`)
}
return response
})

let blocks = response.blocks.nodes.map(block => {
let height = parseInt(block.header.height)
assert(Number.isSafeInteger(height))
Expand All @@ -100,4 +110,28 @@ export class HttpDataSource {
return this.client.graphqlRequest(query, {retryAttempts: Number.MAX_SAFE_INTEGER})
.then(res => validateResult ? validateResult(res) : res)
}

private async retry<T>(request: () => Promise<T>): Promise<T> {
let retries = 0
let pause = 200
while (true) {
try {
return await request()
} catch(err: any) {
if (err instanceof BlocksConsistencyError && retries < 3) {
retries += 1
await wait(pause)
} else {
throw err
}
}
}
}
}


export class BlocksConsistencyError extends Error {
get name(): string {
return 'BlocksConsistencyError'
}
}
2 changes: 1 addition & 1 deletion fuel/fuel-data/src/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Output} from '@subsquid/util-internal-code-printer'
import {DataRequest} from './raw-data';


export function getLatesBlockQuery() {
export function getLatestBlockQuery() {
return `
{
chain {
Expand Down
2 changes: 1 addition & 1 deletion fuel/fuel-data/src/raw-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export type Transaction = GetSrcType<typeof Transaction>

export const Block = object({
header: BlockHeader,
transactions: array(Transaction),
transactions: option(array(Transaction)),
})


Expand Down
2 changes: 1 addition & 1 deletion fuel/fuel-normalization/src/mapping.ts
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export function mapRawBlock(raw: raw.BlockData): Block {
let outputs: TransactionOutput[] = []
let receipts: Receipt[] = []

raw.block.transactions.forEach((tx, index) => {
raw.block.transactions?.forEach((tx, index) => {
transactions.push(mapRawTransaction(tx, index))

tx.inputs?.forEach((input, inputIndex) => {
Expand Down
Loading