Make number functions accept both int and bigint, use strings instead of Buffer in bytes codec #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/config/rush/pnpm-lock.yaml
… of Buffer in bytes codec
vanruch
force-pushed
the
evm-codec-broad-types
branch
from
12a4713 to
05afc70
Compare
belopash
reviewed
Apr 2, 2024
| @@ -7,6 +8,8 @@ import type { Codec } from "./codec"; | |||
| */ | |||
| export type Pretty<T> = { [K in keyof T]: T[K] } & unknown; | |||
|
|
|||
| export type Hex = `0x${string}`; | |||
There was a problem hiding this comment.
I don't think this is needed. Will be very annoyning, better to leave only runtime check
| const ptr = this.u32(); | ||
| this.safeJump(ptr); | ||
| const len = this.u32(); | ||
| this.assertLength(len); | ||
| const val = this.buf.subarray(this.pos, this.pos + len); | ||
| this.jumpBack(); | ||
| return val; | ||
| return `0x${Buffer.from(val).toString("hex")}`; |
There was a problem hiding this comment.
better to reuse our tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly sure about this PR. I feel like working with strings is easier for squid users