Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce updated typegen #250

Closed
wants to merge 13 commits into from
Closed

Introduce updated typegen #250

wants to merge 13 commits into from

Conversation

vanruch
Copy link
Contributor

@vanruch vanruch commented Mar 4, 2024

No description provided.

eldargab
eldargab requested changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@eldargab eldargab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Shitty decoding scheme, that allocates tons of unnecessary intermediate objects and performs a lot of extra work
  • Jaw dropping implementation of bytesToHex, bytesToNumber, bytesToBigInt
  • Formatting mess
  • viem left over

This PR is in desperate need for love!

@vanruch vanruch closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldargab eldargab eldargab requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanruch @eldargab