Include prevalence in login page detection #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rw-access
reviewed
Oct 27, 2023
| not profile.by_sender().solicited | ||
| ( | ||
| not profile.by_sender().solicited | ||
| and not profile.by_sender().prevalence in ("new", "outlier") |
There was a problem hiding this comment.
This right? Has to be unsolicited and old?
There was a problem hiding this comment.
so this won't ever fire on a new sender, the sender basically has to be common and unsolicited? I'm not sure i'm following the logic.
There was a problem hiding this comment.
i was clearly sleep deprived when i wrote this. updating
jkamdjou
commented
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.