Fixing FN: attachment_html_recipient_in_javascript_identifiers.yml #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue where the rule would fail to flag if the recipient and the javascript terms were found in separate exploded pieces of the same file.
|
Mimic showing multiple pickups and no regressions. Many of these were only firing "Any HTML" rules. New Flag. EML 24000 |
jkamdjou
reviewed
Sep 21, 2023
detection-rules/attachment_html_recipient_in_javascript_identifiers.yml
Outdated
Show resolved
Hide resolved
rw-access
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue where the rule would fail to flag if the recipient and the javascript terms were found in separate exploded pieces of the same file.